Skip to content

fix(package_info_plus): proper version.json url for files with special characters #2015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 2, 2023
Merged

fix(package_info_plus): proper version.json url for files with special characters #2015

merged 1 commit into from
Aug 2, 2023

Conversation

fhuonder
Copy link
Contributor

@fhuonder fhuonder commented Aug 2, 2023 •
edited
Loading

Description

Changes the regex that matches the URL for the version.json path generation.
The previous regex did not correctly recognize non-word characters in URLs and created a wrong version.json path.

Related Issues

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I titled the PR using Conventional Commits.
  • I did not modify the CHANGELOG.md nor the plugin version in pubspec.yaml files.
  • All existing and new tests are passing.
  • The analyzer (flutter analyze) does not report any problems on my PR.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate that with a ! in the title as explained in Conventional Commits).
  • No, this is not a breaking change.

@fhuonder fhuonder changed the title WIP: fix wrong cachebuster appendix on version.json fix: create proper version.json url for all types of paths Aug 2, 2023
@fhuonder fhuonder force-pushed the wrong-versionjson-path branch from 1678c3f to 2a83e24 Compare August 2, 2023 07:07
@fhuonder fhuonder changed the title fix: create proper version.json url for all types of paths fix: proper version.json url for files with special characters Aug 2, 2023
@fhuonder fhuonder force-pushed the wrong-versionjson-path branch from 2a83e24 to 7d6a844 Compare August 2, 2023 07:10
@fhuonder fhuonder changed the title fix: proper version.json url for files with special characters fix(package_info_plus): proper version.json url for files with special characters Aug 2, 2023
@fhuonder fhuonder marked this pull request as ready for review August 2, 2023 07:33
@fhuonder fhuonder mentioned this pull request Aug 2, 2023
Closed
7 tasks
@vbuberen vbuberen added package_info_plus stuff related to package_info_plus web labels Aug 2, 2023
vbuberen
vbuberen approved these changes Aug 2, 2023
View reviewed changes
Copy link
Collaborator

@vbuberen vbuberen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for adding tests as well. This fix will be released today.

@vbuberen vbuberen merged commit 235ee39 into fluttercommunity:main Aug 2, 2023
@fhuonder fhuonder deleted the wrong-versionjson-path branch August 2, 2023 09:43
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vbuberen vbuberen vbuberen approved these changes

Assignees
No one assigned
Labels
package_info_plus stuff related to package_info_plus web
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Wrong version.json path when path contains non-word characters
2 participants
@fhuonder @vbuberen