chore(deps): bump web from 0.5.1 to 1.0.0 in /packages/share_plus/share_plus #3105

dependabot · 2024-07-22T21:39:34Z

Bumps web from 0.5.1 to 1.0.0.

Release notes

package:web v1.0.0

Added supertypes' fields to dictionary constructors as dictionaries are allowed to contain those fields.

Empty dictionary constructors now create an empty object instead of being treated like non-object literal external constructors.

Generate MDN API documentation for getters.

Update the docs for generated interface types to reference the MDN Web Docs project.

Address several broken links in API documentation.

Generate APIs based on if they're on track to be a standard and not experimental. This is a looser restriction from the previous requirement that APIs need to be implemented by Chrome, Firefox, and Safari. As part of this, dictionaries and typedefs are only emitted if they're used by a generated API.

Added onUnload event stream to ElementEventGetters extension methods.

Expose ElementStream as a public class.

Require Dart ^3.4.0.

APIs that return a double value now return double instead of num. This is to avoid users accidentally downcasting num, which has different semantics depending on whether you compile to JS or Wasm. See issue #57[] for more details.

Fix an issue where some union types didn't account for typedef nullability. #57: dart-lang/web#57

Changelog

Sourced from web's changelog.

1.0.0

Added supertypes' fields to dictionary constructors as dictionaries are allowed to contain those fields.

Empty dictionary constructors now create an empty object instead of being treated like non-object literal external constructors.

Generate MDN API documentation for getters.

Update the docs for generated interface types to reference the MDN Web Docs project.

Address several broken links in API documentation.

Generate APIs based on if they're on track to be a standard and not experimental. This is a looser restriction from the previous requirement that APIs need to be implemented by Chrome, Firefox, and Safari. As part of this, dictionaries and typedefs are only emitted if they're used by a generated API.

Added onUnload event stream to ElementEventGetters extension methods.

Expose ElementStream as a public class.

Require Dart ^3.4.0.

APIs that return a double value now return double instead of num. This is to avoid users accidentally downcasting num, which has different semantics depending on whether you compile to JS or Wasm. See issue #57[] for more details.

Fix an issue where some union types didn't account for typedef nullability.

#57: dart-lang/web#57

Commits

e89fe49 Publish package:web v1 (#271)
e4c4d81 Bump the github-actions group with 2 updates (#269)
2ae509e Update doc comments, bump version to 1.0.0-wip (#268)
72a806f Account for static members in MDN docs (#267)
82b94c2 Add MAC_FF_META to KeyCode constants (#264)
9e20f7f Update Web IDL to 3.49.0 (#266)
50239e9 Rename members when they collide with return/parameter type names (#265)
6b8a465 Account for typedef nullability (#257)
f6a7d38 Emit double as return value instead of num (#256)
6d22294 Add Float16Array alias (#255)
Additional commits viewable in compare view

You can trigger a rebase of this PR by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

@dependabot rebase will rebase this PR
@dependabot recreate will recreate this PR, overwriting any edits that have been made to it
@dependabot merge will merge this PR after your CI passes on it
@dependabot squash and merge will squash and merge this PR after your CI passes on it
@dependabot cancel merge will cancel a previously requested merge and block automerging
@dependabot reopen will reopen this PR if it is closed
@dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
@dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
@dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

miquelbeltran · 2024-07-23T05:14:20Z

Closes #3093

packages/share_plus/share_plus/pubspec.yaml

Bumps [web](https://github.com/dart-lang/web) from 0.5.1 to 1.0.0. - [Release notes](https://github.com/dart-lang/web/releases) - [Changelog](https://github.com/dart-lang/web/blob/main/CHANGELOG.md) - [Commits](dart-lang/web@v0.5.1...v1.0.0) --- updated-dependencies: - dependency-name: web dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>

vbuberen · 2024-07-23T18:34:46Z

I have just updated the code for web: 1.0.0 and also rebased on latest main to include the new override feature.

However, I am still having issues with flutter build web --wasm command:

miquelbeltran · 2024-07-24T05:29:29Z

Looks like image_picker_for_web 3.0.3 should support web instead of dart:html, maybe the example needs to use dep overrides: https://pub.dev/packages/image_picker_for_web/changelog#303

vbuberen · 2024-07-24T07:53:42Z

Looks like image_picker_for_web 3.0.3 should support web instead of dart:html, maybe the example needs to use dep overrides: https://pub.dev/packages/image_picker_for_web/changelog#303

Yeah, I get it, but how the compilation worked previously when the plugin was migrated to web in #2709? I guess, some changes were introduced when WASM got stable in Flutter 3.22. Because it is not only image_picker, but also url_launcher and some more dependencies. There is a need to upgrade a few more dependencies in the plugin to resolve latest versions that we need for image_picker, etc.

vbuberen · 2024-07-24T08:14:47Z

Ah, yeah, url_launcher in the plugin itself depends on web: ^0.5.0, so there is an issue with resolving web: 1.0.0.
Will need to wait till dependencies are updated.

Let's wait for this one flutter/packages#7202

Bumps [web](https://github.com/dart-lang/web) from 0.5.1 to 1.0.0. - [Release notes](https://github.com/dart-lang/web/releases) - [Changelog](https://github.com/dart-lang/web/blob/main/CHANGELOG.md) - [Commits](dart-lang/web@v0.5.1...v1.0.0) --- updated-dependencies: - dependency-name: web dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>

…us/share_plus/web-1.0.0' into dependabot/pub/packages/share_plus/share_plus/web-1.0.0 # Conflicts: # packages/share_plus/share_plus/pubspec.yaml

…ents

vbuberen · 2024-08-06T07:24:37Z

packages/share_plus/share_plus/README.md

- Flutter >=3.3.0
- Dart >=2.18.0 <4.0.0
+- Flutter >=3.19.0
+- Dart >=3.3.0 <4.0.0


Looks like we had outdated info here

vbuberen · 2024-08-06T07:25:08Z

packages/share_plus/share_plus/example/.gitignore

@@ -32,7 +32,6 @@
 /build/

 # Web related
-lib/generated_plugin_registrant.dart


This is something edited automatically during the build

vbuberen · 2024-08-06T07:28:24Z

packages/share_plus/share_plus/example/web/index.html

-      });
-    }
-  </script>
-  <script src="main.dart.js" type="application/javascript"></script>


Removed to not see the following message in logs:

Warning: In index.html:39: Manual service worker registration deprecated. Use flutter.js service worker bootstrapping instead.

The change is the same as in flutter/packages#7114

vbuberen · 2024-08-06T07:29:37Z

packages/share_plus/share_plus/pubspec.yaml

-  url_launcher_platform_interface: ^2.1.2
-  ffi: ^2.0.1
-  web: ^0.5.0
+  url_launcher_web: ^2.3.2


We only need to update this part of url_launcher to move to web: 1.0.0, but updated the rest as well.

hnvn · 2024-08-06T15:53:12Z

Looking forward this PR

…s/web-1.0.0

miquelbeltran · 2024-08-07T15:26:38Z

Tested by compiling the example with flutter build web, opening a web server from the share_plus/example/build/web folder, and navigating to it from my Android phone using Chrome. Sharing text opened the share sheet as expected.

jonmountjoy · 2024-08-13T07:48:19Z

@miquelbeltran Does the dependency have to be so strict? For example on package_info_plus the dependency is web: ">=0.5.0 <2.0.0 which makes updating much easier.

miquelbeltran · 2024-08-13T08:35:07Z

In this case, the package uses new APIs available on web so 1.0.0 is a requirement.

dependabot bot added dart Pull requests that update Dart code dependencies Pull requests that update a dependency file labels Jul 22, 2024

miquelbeltran requested changes Jul 23, 2024

View reviewed changes

packages/share_plus/share_plus/pubspec.yaml Outdated Show resolved Hide resolved

miquelbeltran added PR: needs manual testing PR: needs review labels Jul 23, 2024

dependabot bot and others added 2 commits July 23, 2024 21:30

chore(share_plus): Update web package to 1.0.0

4a86dc6

vbuberen force-pushed the dependabot/pub/packages/share_plus/share_plus/web-1.0.0 branch from a6a40d3 to 4a86dc6 Compare July 23, 2024 18:33

fix(share_plus): Dart formatting

dedde02

dependabot bot and others added 3 commits July 29, 2024 13:49

chore(share_plus): Update web package to 1.0.0

650aa54

fix(share_plus): Dart formatting

fb3e2bc

vbuberen force-pushed the dependabot/pub/packages/share_plus/share_plus/web-1.0.0 branch from dedde02 to fb3e2bc Compare July 29, 2024 10:49

chore(share_plus): Update web version declaration

159d16c

miquelbeltran self-requested a review July 30, 2024 08:25

miquelbeltran mentioned this pull request Aug 2, 2024

[build]: flutter build web crashed because of this . #3139

Open

8 tasks

vbuberen added 2 commits August 6, 2024 10:06

Merge remote-tracking branch 'origin/dependabot/pub/packages/share_pl…

8a8d711

…us/share_plus/web-1.0.0' into dependabot/pub/packages/share_plus/share_plus/web-1.0.0 # Conflicts: # packages/share_plus/share_plus/pubspec.yaml

chore(share_plus): Update dependencies for web 1.0.0, update requirem…

b5e83b3

…ents

vbuberen reviewed Aug 6, 2024

View reviewed changes

miquelbeltran approved these changes Aug 6, 2024

View reviewed changes

Merge branch 'main' into dependabot/pub/packages/share_plus/share_plu…

4d79611

…s/web-1.0.0

miquelbeltran removed the PR: needs manual testing label Aug 7, 2024

vbuberen merged commit 1f23910 into main Aug 9, 2024
19 of 22 checks passed

vbuberen deleted the dependabot/pub/packages/share_plus/share_plus/web-1.0.0 branch August 9, 2024 08:10

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(deps): bump web from 0.5.1 to 1.0.0 in /packages/share_plus/share_plus #3105

chore(deps): bump web from 0.5.1 to 1.0.0 in /packages/share_plus/share_plus #3105

dependabot bot commented on behalf of github Jul 22, 2024

miquelbeltran commented Jul 23, 2024

vbuberen commented Jul 23, 2024 •

edited

Loading

miquelbeltran commented Jul 24, 2024

vbuberen commented Jul 24, 2024

vbuberen commented Jul 24, 2024 •

edited

Loading

vbuberen Aug 6, 2024

vbuberen Aug 6, 2024

vbuberen Aug 6, 2024

vbuberen Aug 6, 2024

hnvn commented Aug 6, 2024

miquelbeltran commented Aug 7, 2024

jonmountjoy commented Aug 13, 2024

miquelbeltran commented Aug 13, 2024

chore(deps): bump web from 0.5.1 to 1.0.0 in /packages/share_plus/share_plus #3105

chore(deps): bump web from 0.5.1 to 1.0.0 in /packages/share_plus/share_plus #3105

Conversation

dependabot bot commented on behalf of github Jul 22, 2024

package:web v1.0.0

1.0.0

miquelbeltran commented Jul 23, 2024

vbuberen commented Jul 23, 2024 • edited Loading

miquelbeltran commented Jul 24, 2024

vbuberen commented Jul 24, 2024

vbuberen commented Jul 24, 2024 • edited Loading

vbuberen Aug 6, 2024

Choose a reason for hiding this comment

vbuberen Aug 6, 2024

Choose a reason for hiding this comment

vbuberen Aug 6, 2024

Choose a reason for hiding this comment

vbuberen Aug 6, 2024

Choose a reason for hiding this comment

hnvn commented Aug 6, 2024

miquelbeltran commented Aug 7, 2024

jonmountjoy commented Aug 13, 2024

miquelbeltran commented Aug 13, 2024

vbuberen commented Jul 23, 2024 •

edited

Loading

vbuberen commented Jul 24, 2024 •

edited

Loading