Better benchmarks #196
Merged
Better benchmarks #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #196 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 48 48
Lines 1046 1055 +9
=====================================
+ Hits 1046 1055 +9
Continue to review full report at Codecov.
|
Avaq
force-pushed
the
avaq/sanctuary-benchmark
branch
2 times, most recently
from
d5a9c63
to
ed687bc
Compare
Avaq
force-pushed
the
avaq/sanctuary-benchmark
branch
2 times, most recently
from
4bf78e5
to
8199a06
Compare
2 tasks
Avaq
force-pushed
the
avaq/sanctuary-benchmark
branch
2 times, most recently
from
d7b101a
to
a3b08c5
Compare
Avaq
force-pushed
the
avaq/sanctuary-benchmark
branch
from
a3b08c5
to
6597e13
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This overhauls the old benchmarks with new ones defined using sanctuary-js/sanctuary-benchmark#1
I've opened this PR in part to assert whether the current state of
sanctuary-benchmarkis satisfactory.The only benchmarkOne of the benchmarks currently included is one comparing Fluture to Folktale. It's really just there for illustrative purposes. I'll be working to include more benchmarks with the goal of avoiding performance regressions. In particular, I'm afraid my work towards fixing #153 might affect performance in unexpected ways.