Improve support for modular javascript runtimes #429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
Avaq
commented
Jun 6, 2020
Avaq
commented
Jun 6, 2020
|
After some fiddling with file names, link locations, and TypeScript, it should now be possible for you to test this yourself:
|
|
Aside from downloading it over jsdelivr, you can also download it directly from the deno.land proxy: https://deno.land/x/gh:fluture-js:Fluture@dist2/dist/module.js |
Avaq
commented
Jun 7, 2020
This file can be consumed by any runtime that can load EcmaScript modules. Most prominently, web browsers, and Deno. As a bonus, Deno or other runtimes that support TypeScript will also see a reference for where to download the typings.
I believe this was added by mistake when the TypeScript types were introduced. I think it was probably copy pasted over from Tushar's personal TypeScript overrides for the 'fluture' module. It never caused any problems, because users have always been able to import Fluture from the 'fluture' module. However, this changes with Deno's dependency model. This commit removes the module declaration wrapper around the TypeScript types, forcing TypeScript to make the association with the relevant module in a different way. In particular, TypeScript should now make the association based either on the location of the file (when imported using Node's require algorithm), or based on a <reference> directive, such as the one used in dist/module.js.
dicearr
approved these changes
Jun 9, 2020
Comment on lines
+103
to
+107
| const getPackageName = function (file) { | ||
| return Future.node (function (done) { fs.readFile (file, 'utf8', done) }) | ||
| .pipe (Future.chain (Future.encase (JSON.parse))) | ||
| .pipe (Future.map (function (x) { return x.name })) | ||
| } |
There was a problem hiding this comment.
It's a little strange to see const alongside function expressions. Is there a reason to avoid arrow functions here?
There was a problem hiding this comment.
Hm. You're right. This example was meant to illustrate what Fluture usage looks like in older runtimes. I guess I missed the const.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In particular, I'd like Fluture to be easy to use with Deno, but other runtimes, such as modern browsers, should also benefit from these changes.
Changes
I've added a pre-release build step to create a modular bundle alongside the already existing script bundle. I've also updated the documentation to draw more attention to the existence of these bundles, mention usage in Deno, and lower the emphasis on using the CommonJS version.