Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kvs: call content.flush before checkpoint #6237

Open
chu11 opened this issue Aug 27, 2024 · 0 comments · May be fixed by #6240
Open

kvs: call content.flush before checkpoint #6237

chu11 opened this issue Aug 27, 2024 · 0 comments · May be fixed by #6240
Assignees

Comments

@chu11
Copy link
Member

chu11 commented Aug 27, 2024

In the KVS module a checkpoint is done right before the module exits. However content.flush is not called. Thus there is a chance the checkpoint is invalid b/c it is not guanrateed that all KVS stores have been written to disk.

@chu11 chu11 self-assigned this Aug 27, 2024
chu11 added a commit to chu11/flux-core that referenced this issue Aug 27, 2024
Problem: When the KVS module is unloaded, a checkpoint of the root
reference is attempted.  However, a content.flush is not done
beforehand.  This could result in an invalid checkpoint reference
as data is not guaranteed to be flushed to the backing store.

Solution: Call content.flush before checkpointing.

Fixes flux-framework#6237
@chu11 chu11 linked a pull request Aug 27, 2024 that will close this issue
chu11 added a commit to chu11/flux-core that referenced this issue Aug 27, 2024
Problem: When the KVS module is unloaded, a checkpoint of the root
reference is attempted.  However, a content.flush is not done
beforehand.  This could result in an invalid checkpoint reference
as data is not guaranteed to be flushed to the backing store.

Solution: Call content.flush before checkpointing.

Fixes flux-framework#6237
chu11 added a commit to chu11/flux-core that referenced this issue Aug 27, 2024
Problem: When the KVS module is unloaded, a checkpoint of the root
reference is attempted.  However, a content.flush is not done
beforehand.  This could result in an invalid checkpoint reference
as data is not guaranteed to be flushed to the backing store.

Solution: Call content.flush before checkpointing.

Fixes flux-framework#6237
chu11 added a commit to chu11/flux-core that referenced this issue Aug 27, 2024
Problem: When the KVS module is unloaded, a checkpoint of the root
reference is attempted.  However, a content.flush is not done
beforehand.  This could result in an invalid checkpoint reference
as data is not guaranteed to be flushed to the backing store.

Solution: Call content.flush before checkpointing.

Fixes flux-framework#6237
chu11 added a commit to chu11/flux-core that referenced this issue Aug 29, 2024
Problem: When the KVS module is unloaded, a checkpoint of the root
reference is attempted.  However, a content.flush is not done
beforehand.  This could result in an invalid checkpoint reference
as data is not guaranteed to be flushed to the backing store.

Solution: Call content.flush before checkpointing.

Fixes flux-framework#6237
chu11 added a commit to chu11/flux-core that referenced this issue Sep 4, 2024
Problem: When the KVS module is unloaded, a checkpoint of the root
reference is attempted.  However, a content.flush is not done
beforehand.  This could result in an invalid checkpoint reference
as data is not guaranteed to be flushed to the backing store.

Solution: Call content.flush before checkpointing.

Fixes flux-framework#6237
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant