fixed: invalid json after injecting object or array in values template #492
Conversation
| // template after tmpl.Execute | ||
| // `{ "my_object":"${{ .my_object }}" }` ---> `{ "my_object":"{"this":"object"}" }` | ||
| // We therefore need to remove unnecessary strings making it valid JSON again | ||
| type replacement struct { |
There was a problem hiding this comment.
text replacement like this sounds like sub-optimal for me.
let's discuss a better way to handle this conversion.
There was a problem hiding this comment.
I definitely agree that this is not the best solution. I was also thinking of using a function inside the template, for example:
...
values:
my_object: ${{ .my_object | toObject }}
my_array: ${{ .my_array | toArray }}
Would this be an acceptable solution? This is more explicit at least, but could be tiresome as one might think that this should work out of the box.
There was a problem hiding this comment.
Would you write some unit test cases to cover these cases, also for primitive values like strings itself?
There was a problem hiding this comment.
I can do that, but for which approach? The string replacement or the function based approach?
There was a problem hiding this comment.
The correctness of the replacement I would say.
I would expect that the result JSON gets parsed correctly for
- primitive values (string, number, boolean)
- object
- array
- map
fixes issue #491
It removes quotes around objects and arrays which happens when an object or array is injected in a template inside the values field.