-
Notifications
You must be signed in to change notification settings - Fork 599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Helm use case intro page #1255
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@scottrigby I think we could add a section on secrets management and explain how valuesFrom work with secrets decrypted by kustomize-controller. Another thing that's missing from here is the automated upgrade feature (semver range) and automated rollback.
Should I just summarize and link to the existing doc pages on that?
|
Yes, for each topic we need to explain what's the GitOps way of doing it and why it's useful, then link to each doc.
This doc is about v2, I would not mention v1 at all. |
While there's a note about the feature here https://toolkit.fluxcd.io/components/helm/controller/, and the API pages have details, the best description for this is currently in the Helm Operator -> Controller migration doc https://toolkit.fluxcd.io/guides/helm-operator-migration/#defining-a-rollback-uninstall-configuration and https://toolkit.fluxcd.io/guides/helm-operator-migration/#automated-rollbacks. Perhaps the bulk of this should be moved to the helm use case intro page, and that section could be linked to from the operator->controller migration page instead of the info living there. |
Let’s copy and adapt the rollback info in this doc. I want to avoid sending people from the migration guide to other places. The audience for this document is very different to the migration one, so duplicating some info is fine. |
@stefanprodan WDYT? Trying to cover bases with simple examples, while duplicating as little as possible from other areas of the docs. I did follow your suggestion about copying adapt and rollback. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks @scottrigby 🏅
Signed-off-by: Scott Rigby <scott@r6by.com>
Signed-off-by: Scott Rigby <scott@r6by.com> Co-authored-by: Stefan Prodan <stefan.prodan@gmail.com>
…e plus SOPS, semver range policies, and auto uninstalls and rollbacks Signed-off-by: Scott Rigby <scott@r6by.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome, thank you very much @scottrigby 💯 🥇
What is the simplest way to explain how Flux works with Helm to existing Helm users?
There's a lot more we can say, but is there anything critical we think should go into an intro that I'm missing?
See fluxcd/website#120