Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add guide to setup GPG commit verification #409

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

fl42
Copy link

@fl42 fl42 commented Jul 13, 2021

Hello,

This is my first documentation PR, feel free to give me feedback.

TODO:

  • flux bootstrap commits are not signed, what is the best option to handle them? (git commit --amend?)

Signed-off-by: FL42 <46161216+fl42@users.noreply.github.com>
@oliverbaehler
Copy link
Contributor

Hi, just as little input how we are using gpg.

The Kustomization for the gitRepository looks like this:

apiVersion: kustomize.config.k8s.io/v1beta1
kind: Kustomization
secretGenerator:
- name: catalog-gpg-pub-keys
  files:
  - ../../../gpg/member-1.asc
  - ../../../gpg/member-2.asc
  type: Opaque
generatorOptions:
 disableNameSuffixHash: true

And that's the gitRepository itself:

---
apiVersion: source.toolkit.fluxcd.io/v1beta1
kind: GitRepository
metadata:
  name: catalog
spec:
  interval: ${git_repo_interval:-${global_interval:-1m}}
 ....
  verify:
    mode: head
    secretRef:
      name: catalog-gpg-pub-keys

Maybe you could add this approach too.

@kingdonb
Copy link
Member

kingdonb commented Jun 4, 2024

There is bootstrap signing

Thank you for contributing this, I noticed that the docs around commit signing and around flux bootstrap git... signing commits are a bit undercooked! Maybe we can still use some of this. It looks like commit signing in bootstrap was added some time after you contributed this PR, even if it was a while ago... fluxcd/flux2#1854

I wrote some notes about my experience signing a commit with flux bootstrap here on another issue report:

fluxcd/flux2#4519 (comment)

I think the keyring file is going to be the outlier, if we want the docs to be complete, it will be hard to cover all the different possibilities of whether you already have a keyfile or need to export one from the OS key store, but we can probably find an upstream document that covers all of that reasonably well (🤞)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants