Add flags for issuer/subject OCI signature verification #4727
+110
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makkes
force-pushed
the
verify-issuer-subject
branch
from
1fc8239
to
74bd852
Compare
makkes
added
enhancement
makkes
force-pushed
the
verify-issuer-subject
branch
from
74bd852
to
41a0cf3
Compare
souleb
reviewed
Apr 16, 2024
| --tag=6.6.2 \ | ||
| --interval=10m \ | ||
| --verify-provider=cosign \ | ||
| --verify-subject="^https://github.com/stefanprodan/podinfo/.github/workflows/release.yml@refs/tags/6.6.2$" \ |
There was a problem hiding this comment.
perhaps verify-identity to match the cosign flag --certificate-identity
There was a problem hiding this comment.
We are matching our own API fields which are issuer and subject.
This change introduces two new flags to `create source oci` for providing the values to the `OCIRepository.spec.verify.matchOIDCIdentity.(issuer,subject)` fields. Signed-off-by: Max Jonas Werner <mail@makk.es>
makkes
force-pushed
the
verify-issuer-subject
branch
from
41a0cf3
to
1bb9254
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change introduces two new flags to
create source ocifor providing the values to theOCIRepository.spec.verify.matchOIDCIdentity.(issuer,subject)fields.