Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

helm/v3: prevent spurious upgrades due to missing dependencies #196

Merged
merged 2 commits into from
Jan 10, 2020

Conversation

hiddeco
Copy link
Member

@hiddeco hiddeco commented Jan 10, 2020

Fixes #194, likely also addresses #8 (comment), #8 (comment)

As Helm v3 only returns chart dependencies after an upgrade, but
not when getting a release. Divergences are still captured by the
fact that either the `release.Manifest` or `chart.Files` will
differ based on a dependency change.
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hiddeco hiddeco merged commit a783db7 into master Jan 10, 2020
@hiddeco hiddeco deleted the helm/spurious-upgrades branch January 10, 2020 13:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Charts with dependencies are upgraded every cycle
2 participants