Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Honor the default Git ref when reconciling charts source #253

Merged
merged 1 commit into from
Jan 28, 2020
Merged

Honor the default Git ref when reconciling charts source #253

merged 1 commit into from
Jan 28, 2020

Conversation

sa-spag
Copy link
Contributor

@sa-spag sa-spag commented Jan 28, 2020

Fixes #248.

@sa-spag sa-spag requested a review from hiddeco January 28, 2020 17:27
Fixes a bug where HelmReleases that do not specify a `.spec.chart.ref`
are "dry-run upgraded" every Git mirror sync for no reason.
Copy link
Member

@hiddeco hiddeco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hidden in plain sight, thanks @sa-spag 🥇

@hiddeco hiddeco merged commit d1efa70 into fluxcd:master Jan 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Repeated dry-run upgrade out of the expected periodic chart sync
2 participants