This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Adding securityContext options at the pod and container level. #494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The tests seem to be failing. |
|
|
containerSecurityContext: {}
helmOperator: {}
tiller: {}needs to be change to containerSecurityContext:
helmOperator: {}
tiller: {} |
saada
suggested changes
Jul 29, 2020
|
Thanks for contributing! Just a few pointers to get these tests passing |
|
@hiddeco can we rerun tests? |
|
Rebasing and force-pushing will trigger a new build while also getting rid of the |
hiddeco
reviewed
Jul 31, 2020
chart/helm-operator/Chart.yaml
Outdated
| @@ -1,6 +1,6 @@ | |||
| apiVersion: v1 | |||
| appVersion: "1.2.0" | |||
| version: 1.1.0 | |||
| version: 1.1.1 | |||
There was a problem hiding this comment.
FYI: we do not bump versions on changes, but bump it on release.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allowing the configuration of
SecurityContextat the pod and individual container levels.