Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

fix: make passing gitconfig as a value optional #551

Merged

Conversation

Carles-Figuerola
Copy link
Contributor

Description

Adding a boolean option to not create the kubernetes secret when git.config.enable is set to true. This allows gitconfigs with actual secret information to be stored in kubernetes through a different pipeline rather than have actual secrets stored in the values section of the helm release (valid for autmated deploys where the deployment metadata is stored somewhere public)

As an example, for simplifying git auth in our infrastructure, we use a gitconfig like this to transparently authenticate all git operations:

url "https://<USERNAME>:<PASSWORD>@git.mydomain.com/"]
        insteadOf = https://git.mydomain.com/
        insteadOf = ssh://git@git.mydomain.com/
        insteadOf = git@git.mydomain.com:

@hiddeco hiddeco added the chart Related to the Helm chart label Feb 9, 2021
Copy link
Member

@hiddeco hiddeco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @Carles-Figuerola 🌻

@hiddeco hiddeco merged commit c08e777 into fluxcd:master Feb 9, 2021
@Carles-Figuerola Carles-Figuerola deleted the cfiguerola/gitconfig-secret-optional branch February 10, 2021 16:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
chart Related to the Helm chart
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants