Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime/leaderelection: add GenerateID and update dependencies #526

Merged
merged 2 commits into from
Mar 29, 2023

Conversation

hiddeco
Copy link
Member

@hiddeco hiddeco commented Mar 29, 2023

No description provided.

@hiddeco hiddeco added enhancement New feature or request area/runtime Controller runtime related issues and pull requests labels Mar 29, 2023
runtime/controller/watch.go Outdated Show resolved Hide resolved
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @hiddeco

@hiddeco hiddeco force-pushed the leader-election-id branch 2 times, most recently from 345676b to c85fe93 Compare March 29, 2023 09:19
@hiddeco hiddeco changed the title runtime: add GenerateLeaderElectionID and update dependencies runtime/leaderelection: add GenerateID and update dependencies Mar 29, 2023
This commit allows for the generation of a unique leader election ID
based on a base string and a set of arbitrary strings which are used
to generate a (short) SHA-256 sum to suffix with.

Signed-off-by: Hidde Beydals <hidde@hhh.computer>
- github.com/onsi/gomega v1.27.5
- k8s.io/client-go v0.26.3
- k8s.io/component-base v0.26.3
- sigs.k8s.io/controller-runtime v0.14.6

Signed-off-by: Hidde Beydals <hidde@hhh.computer>
Copy link
Contributor

@darkowlzz darkowlzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hiddeco hiddeco merged commit 6bf578d into main Mar 29, 2023
@hiddeco hiddeco deleted the leader-election-id branch March 29, 2023 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/runtime Controller runtime related issues and pull requests enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants