runtine: Add cluster.proxy-url to kubeconfig allow fields
#747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garyhodgson
requested review from
darkowlzz,
hiddeco and
stefanprodan
as code owners
This was referenced Mar 25, 2024
|
Please signoff your commit and force push, docs here: https://github.com/fluxcd/pkg/pull/747/checks?check_run_id=23046074271 |
stefanprodan
added
the
area/runtime
stefanprodan
changed the title
cluster.proxy-url to kubeconfig allow fields
garyhodgson
force-pushed
the
issue-746_kubeconfig-proxy-url
branch
3 times, most recently
from
254ad85
to
19e2ad6
Compare
|
Hi @stefanprodan - Apologies for not including it in the original request - I believe the check should now be ok. |
|
@garyhodgson we've fixed the CI issues in main, please rebase and force push. |
… client Signed-off-by: Gary Hodgson <contact@garyhodgson.com>
garyhodgson
force-pushed
the
issue-746_kubeconfig-proxy-url
branch
from
19e2ad6
to
e60b226
Compare
stefanprodan
approved these changes
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #746
Fix: fluxcd/kustomize-controller#1042