Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return a DiffTypeExclude when exclusion annotation is set in cluster #752

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

souleb
Copy link
Member

@souleb souleb commented Mar 28, 2024

We want to enable this behaviour for use cases where different controllers must coordinate in order to mutate a resource.

ref: fluxcd/helm-controller#922

Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @souleb 🥇

@souleb souleb added enhancement New feature or request area/server-side-apply SSA related issues and pull requests labels Mar 29, 2024
We want to enable this behaviour for use cases where different
controllers must coordinate in order to mutate a resource.

Signed-off-by: Soule BA <bah.soule@gmail.com>
@souleb souleb force-pushed the handle-in-cluster-annotation branch from dcc68d0 to 4971c85 Compare April 2, 2024 09:19
@stefanprodan stefanprodan merged commit 288cd7a into main Apr 2, 2024
11 checks passed
@stefanprodan stefanprodan deleted the handle-in-cluster-annotation branch April 2, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/server-side-apply SSA related issues and pull requests enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants