Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take relative paths in account for Bucket revision #403

Merged
merged 1 commit into from
Jul 26, 2021

Conversation

hiddeco
Copy link
Member

@hiddeco hiddeco commented Jul 23, 2021

This commit changes the checksum method which is used to calculate the
revision of a Bucket source, so that the file paths are taken into
account and directory structure changes can be observed.

@hiddeco hiddeco added the area/bucket Bucket related issues and pull requests label Jul 23, 2021
This commit changes the checksum method which is used to calculate the
revision of a Bucket source, so that the file paths are taken into
account and directory structure changes can be observed.

Signed-off-by: Hidde Beydals <hello@hidde.co>
@hiddeco hiddeco merged commit be5d10e into main Jul 26, 2021
@hiddeco hiddeco deleted the bucket-revision-path branch July 26, 2021 12:01
@sata
Copy link
Contributor

sata commented Jul 26, 2021

Ah, shame, was just about to raise a PR: sata@adc7a6f .. Trying to make it all nice with Ginkgo haha! Next time :)

@hiddeco
Copy link
Member Author

hiddeco commented Jul 26, 2021

@sata ah, that's too bad. A note for future contributions, we are dropping Ginkgo soon, see the working progress in #361 (specifically 791951b). More extensive tests are however still welcome, even for just the checksum logic. :-)

@sata
Copy link
Contributor

sata commented Jul 26, 2021

@sata ah, that's too bad. A note for future contributions, we are dropping Ginkgo soon, see the working progress in #316 (specifically 791951b). More extensive tests are however still welcome, even for just the checksum logic. :-)

I can understand, it felt quite clunky.. I shall remember this.

FYI https://golang.org/doc/go1.16#ioutil :)

@hiddeco
Copy link
Member Author

hiddeco commented Jul 26, 2021

I can understand, it felt quite clunky..

Yes, that was our experience too, while the Gomega assertion library is excellent (and still in use).

FYI golang.org/doc/go1.16#ioutil :)

Ah, thanks. I remember having read this but had forgotten about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/bucket Bucket related issues and pull requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants