Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Case: Adding Given-When-Then #27

Closed
lvanvugt opened this issue Jun 21, 2020 · 6 comments
Closed

Use Case: Adding Given-When-Then #27

lvanvugt opened this issue Jun 21, 2020 · 6 comments
Assignees
Labels
enhancement New feature or request version A To be picked up right away
Milestone

Comments

@lvanvugt
Copy link
Contributor

lvanvugt commented Jun 21, 2020

The following flowchart shows the use case:

Use Case (#27) - Adding Given-When-Then

Exceptions

  • Non-alpabathic or non-numerical characters should not be ported to helper function names
  • Given/When/Then description should not have unlimited length as AL function names have a max length of 120 characters
    • I suggest to build logic that checks allowed length in Given/When/Then description based on text with "to be removed" non-alpabathic or non-numerical characters

Settings

  • Make setting possible that user can set max length to Given/When/Then description himself
  • Standard each newly created helper function should get an error statement assigned with test " is not yet implemented"; user should be able to turn this of with a setting
  • A setting is needed to provide for each helper function type, i.e. Given, When or Then, a syntax allowing, for example, to add a standard term (verb) to the name.
    • Example were Verify is added as prefix to THEN helper function (see also behavior of the ATDD.TestScriptor PowerShell module)
THEN clause: Warehouse shipment line is deleted
function name:  VerifyWarehouseShipmentLineIsDeleted();
lvanvugt pushed a commit that referenced this issue Jun 21, 2020
@lvanvugt lvanvugt added enhancement New feature or request version A To be picked up right away labels Jun 21, 2020
@martonsagi
Copy link
Collaborator

@DavidFeldhoff
Hi,

Settings object will be sent in a simple key->value format to the backend.

image

@lvanvugt
Copy link
Contributor Author

@DavidFeldhoff does it make sense to include #16 here already?

@DavidFeldhoff
Copy link
Collaborator

Yes, definitely 👍

martonsagi added a commit that referenced this issue Jul 20, 2020
@martonsagi
Copy link
Collaborator

@DavidFeldhoff
I have added the UI parts to AddingGivenWhenThen branch. You should now reveice nofitication on the Backend when scenario or given/when/then data changes.

@DavidFeldhoff
Copy link
Collaborator

DavidFeldhoff commented Jul 27, 2020

@lvanvugt : It's ready to test in the "AddingGivenWhenThen" Branch

@lvanvugt
Copy link
Contributor Author

lvanvugt commented Oct 24, 2020

All tests seem to run fine. Retest will be done later when everything needs to be tested again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request version A To be picked up right away
Projects
None yet
Development

No branches or pull requests

3 participants