Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vlocity-Data-Package crashes sfp deployment #115

Open
Schuchie opened this issue Aug 31, 2024 · 0 comments · May be fixed by #116
Open

Vlocity-Data-Package crashes sfp deployment #115

Schuchie opened this issue Aug 31, 2024 · 0 comments · May be fixed by #116
Labels

Comments

@Schuchie
Copy link

Schuchie commented Aug 31, 2024

Describe the bug
A vlocity-data-package can break the whole deployment process, when it contains a xml-file which isn't a metadata. In specific the pre and post deployers are not handling that case correctly.

To Reproduce
Steps to reproduce the behavior:

  1. Add a sfdx-package as type data
  2. Insert a datapack with a random .xml-File
  3. Try to deploy/create pool.

Expected behavior
Deployment or Pool Creation should work without any issue. The pre-/post-deployers should not break with such a kind package.

Screenshots
image

Platform Details (please complete the following information):

  • OS: Mac/GitHub
  • Version [e.g. CLI Version eg: 1.6.6]: @flxbl-io/sfp/39.2.1 darwin-arm64 node-v18.20.3
  • Salesforce CLI(sfdx cli) Version: @salesforce/cli/2.44.8 darwin-arm64 node-v18.20.3
  • CI Platform: GitHub or local

Additional context
Workaround: Just ignore the whole datapacks via .forceignore. (maybe the correct approach for datapacks?)

Following code runs into an error, when a xml file is contained in a datapack:

// sfp/src/core/package/packageInstallers/InstallPackage.ts:313
// sfp/src/core/package/packageInstallers/InstallPackage.ts:360

let componentSet = ComponentSet.fromSource(
    path.join(this.sfpPackage.projectDirectory, this.sfpPackage.packageDirectory)
);
Schuchie added a commit to Schuchie/sfp that referenced this issue Aug 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant