-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PG16 Support #233
PG16 Support #233
Conversation
|
||
|
||
# TimescaleDB and PostGIS | ||
RUN echo "deb https://packagecloud.io/timescale/timescaledb/ubuntu/ jammy main" > /etc/apt/sources.list.d/timescaledb.list \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Timescale isn't compatible with noble yet... While jammy seems to work, some additional testing is needed.
Related:
timescale/timescaledb-toolkit#799
postgresql-contrib-${PG_MAJOR_VERSION} | ||
|
||
# Repmgr | ||
RUN curl -L http://launchpadlibrarian.net/722514158/postgresql-${PG_MAJOR_VERSION}-repmgr_${REPMGR_VERSION}_amd64.deb -o postgresql-${PG_MAJOR_VERSION}-repmgr_${REPMGR_VERSION}_amd64.deb && \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could this also cover arm64? This is mainly for building an image on Mac for local testing 🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How are you testing locally?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm testing the building of the image.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you're just testing the build process you can specify the platform.
E.G.
docker build . --platform linux/amd64
Ran the following successful tests with this image:
Please let me know if I should test anything else. |
Nice! We'd just need to test out the various flyctl commands and then do the same with timescaledb. |
FWIW all these tests were run with flyctl commands. Were there any I missed? All of the above tests were successfully run with timescaledb too, no issues. |
Postgres 16 requires repmgr 5.4.1, which relies on
glibc >= 2.38
. This glibc version has not yet reached Debian stable, so in an effort to get PG 16 out we are switching to an ubuntu noble24.04
. Since this change would lead to collation issues with existing setups, we are just going to just maintain separate Dockerfiles per major PG version.While basic provisioning seems to work fine, some additional testing will be needed.