-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved engine performance and flight dynamics #1295
Improved engine performance and flight dynamics #1295
Conversation
See my comments on an earlier version of the modification here: #1204 (comment) |
This works beautifully as described. Thank you 1000x better |
I am currently working on an further improved engine parameter table. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
I tested this PR, great work. Date of testing: 13 Oct, 2020 T/O weight: 67500kg Low N1 performance is realistic. I taxied in idle thrust with no issues. Lift generated by flaps is much better. Above FL280 though, the climb rate slowed down to 800fpm till FL310 where I initially leveled off to burn some fuel. Descent performance was stunning, had to use the spoilers to slow down sometimes. Approach was realistic with addition of flaps requiring pitch changes just like the IRL video. Overview: Realistic acceleration/deceleration. Great low N1 performance. High N1 performance might have to be tweaked. |
Will do. |
Do you know the N1 you had during climb?
Will look into that as well. Could you please send (or link) me the cruise perf charts, that would be nice.
|
@nobodyn0se big thanks. Hell yeah I like the imperial system for weights... still not using metric ffs. |
Discord: sphectrum#6484 Testing technique: Gate start/cold and dark, full flight Tested comparing to latest master during a full flight with a manually programmed MCDU. Overall Rating: Good, needs some more tweaks |
@donstim big thanks! btw metric system is better ^^ |
Can you please explain to me what you mean? I don't understand. And yes it is tricky atm via the N1 to tweak high alt climb speeds etc without rocketing out of the airport. |
Sure, do you understand how the table is formatted? I assume you do, but just in case...there are sets of 11 numbers separated by commas. The first 11 numbers are the Mach numbers in the table. Actually, the very first number is meaningless. The next 10 are the Mach numbers - 0 through 0.9 by 0.1. For each subsequent group of 11 numbers, the first number is the N1 for that group of Mach numbers. The next ten numbers are the thrust factors for the 10 Mach numbers (0 Mach through 0.9 Mach by 0.1). So, my thought is to leave the thrust factors for the low N1s (maybe up though 60 or 70?) for all Mach numbers the way you have them. For the higher N1s (above 60 or 70), at Mach numbers of about 0.4 or lower, also no change. But for the higher N1s at higher Mach numbers, increase the thrust factor such that for Machs of 0.7 and above maybe increase the thrust factor above what was in the table before you started. It would probably be best to plot it against Mach number for each of these higher N1s so that this is done smoothly. Does that make sense? |
@donstim but you do talk about this table right? n1_and_mach_on_thrust_table. |
Yes, exactly. I have just taken an initial cut at it by doing the following: At N1s of 70 and above, I made the following changes: This is just an initial cut - I haven't flown it yet. |
Sounds great! I will try this approach and lets see how crazy we need to crank these numbers up xD |
Flying now. My first impression is that I definitely overdid it with the higher Mach/higher N1 values. Going to revert back to the original values (before either of our mods) for Mach 0.7 to 0.9 - no 3% or 5% boost and see how that looks. Edit: After those changes, thrust for N1 still seems too high. Climb rate is a little high, but mainly at cruise, N1 is way too low. Also noticed that the climb N1s given on the ECAM gauges goes above the rating value given in the upper right corner of the ECAM. Wish I knew how what controls those values in MSFS. Seems like if the N1 shown on the gauges was limited to no greater than the rating N1 when in open climb, things would match up better. |
I have done some more tweaking to the engine performance table. |
@donstim I noticed that ECAM shenaniganz too. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Oh I thought you meant the speed tape. No that will of course not change. Why should it? |
Again, the speed tape does not reflect the real world, since this flight model is not accurate. |
Don't know why, did not touched it.
I have seen that as well as on approach when FLAPS 3 are selected that managed speed will increase by a few knots and VLS and VApp in mcdu are different. (This is only when on FLAPS 3). |
Oh you referring to the yellow VLS band. Now I get it :D yes that should match you are right. And I don't see the point why the MCDU Vapp should change in selected speed mode. @MisterChocker Isnt the VLS in the speedtape linked to the calculated VLS in the MCDU? |
@St54Kevin currently it's not. The VLS in the speedtape is calculated with simvars, the MCDU uses real tables. |
LGTM, minor issues that will be fixed with flight model and my personal optimization of PFD elements |
* Improved engine performance * Improved flight dynamics * Improved speedbrakes / spoilers * Improved flight dynamics, pr changes * added n2_to_n1_table again * Adjusted engine performance * Reduced taxiing acceleration. * Fixed climb speeds, cruise N1s and ff * reworked aerodynamics, lowered idle thrust * reduced pitch on landing * improfed lift and pitch * integrated appraoch speeds * converted if to switch * fixed lint errors * fixed lint errors #2 * fixed lint errors flybywiresim#3 * increased flaps lift for take off * improved alpha prot range * added changes to changelog.md Co-authored-by: Benjamin Dupont <benjozorkfr@gmail.com>
After I updated the A32NX#1295 version, the entire throttle response is very strange. When idling (F1), it will push forward? Unless I reverse the throttle, I can stop. I feel that the throttle position is confused. |
I think, I remember from old FS9/Phoenix times, that one had to give a little bit throttle to overcome the initial inertia, but then it kept rolling @ idle. |
@dc1ps2 0% throttle does not mean 0% acceleration. It does not work like a car. Actually when driving automatic transmission, the car will engage the clutch and start rolling, when the pressure on the brake paddle is lowered. |
So now if I want to stop completely, what should I do? |
Hit the brakes, then engage the parking brake |
It's the same IRL. The plane accelerates with idle. If you have a light aircraft you have to brake a lot while taxiing |
@MisterChocker Not sure if I should log a bug for this or not (not a real pilot, no clue how the a/c should behave in this situation): at high temperatures, TO/GA thrust oscillates wildly. See: https://streamable.com/uga58q The above clip was taken at 37 celsius OAT. For that temperature, FLEX solved the issue for me and stopped the oscillations. However, going up to 45 degrees OAT, FLEX behaves the same as TO/GA. From what I noticed, thrust is reduced in order to keep EGT out of the red. FLEX seemed to have a higher tolerance to red EGT than TO/GA for some reason. This happened to me regardless of wether I spawned on the runway or cold&dark. Above location is Paro with live weather (I initially thought altitude was the reason), but it's reproducible everywhere, as long as you set temperature from the weather menu. |
@Lessar277 we need a FADEC in order to sort that and we are working on that as well. |
Well then the new MFS update broke something. Wouldn't actually surprise me... |
@ElSrJuez this change is not present in 0.4.1. |
Roger that, I asked on Discord and was left under the impression that all commits to master were included in 0.4.1. Anyway, thanks. I kind of figured that later... this is planned for 0.5, no? |
Fuel consumption is roughly halved (~30 KG/min) on the current Dev (8-Nov). |
Fixes #210
Fixes #359
Fixes #824
Fixes #850
Fixes #917
Fixes #974
Fixes #984
Fixes #1034
Fixes #1043
Fixes #1166
Fixes #1173
Fixes #1204
Fixes #1255
Fixes #1375
Fixes #1377
Fixes #1442 (VApp calculation)
(are all about climb rate/cruise attitude/not able to reach cruise/stalls/fuel consumption)
Summary of Changes
enables taxiing on idle thrust and also impacts aircraft performance in flight e.g. approach or decent
prevents early stalling of the aircraft on landing
improves the overall feeling of the aircraft in flight
deceleration on approach now slower
pitch now changes noticeable when flaps position changes
makes aircraft (more) responsive
The following speeds are now calculated based on charts below
This is an issue to be solved by the future flight model
This PR actually solves as a HOTFIX meanwhile development on the final engine model continues.
Screenshots (if necessary)
References
https://www.youtube.com/watch?v=cv41hm4JEB8&feature=youtu.be&t=100
https://www.youtube.com/watch?v=FODhSJucbK0
https://www.youtube.com/watch?v=rhI5XGwlnaI
Additional context
Discord username (if different from GitHub): DerL30N#3751
How to download the PR for QA
Every new commit to this PR will cause a new A32NX artifact to be created and uploaded.
The build.py will have already been run with the latest changes, so no need to rerun it once you download the zip.