Hide BingMap on ND when no weather or terrain #232
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially solves #57 , it hides the airports on the ND when no terrain or weather is showing, but airports will still show when terrain is on and above 500 AGL.
We are hiding the airports by hiding the BingMap, which draws the airports, terrain, and weather.
When weather is on and terrain is off, the weather radar is displayed, and it clears the background with black, so airports are already not displayed when weather is displayed.
When terrain is on and you are at or above 500 AGL, the airport will still be rendered.
We cannot fix this without a patch from Asobo.
There are no function exposed through Coherent that can control whether the airports are rendered or not (that we found).
The user should not see any differences when weather is being displayed (weather on and terrain off), or when terrain is on and the plane is at or above 500 AGL.
Before (weather off, terrain off, 0 AGL) (dev branch):
After (weather off, terrain off, 0 AGL):
Before (weather off, terrain on, 0 AGL) (dev branch):
After (weather off, terrain on, 0 AGL):
After (weather off, terrain on, 500 AGL):
The airport is still expected to be seen in the above picture for the reasons mentioned above.