Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide BingMap on ND when no weather or terrain #232

Merged
merged 2 commits into from
Sep 5, 2020

Conversation

adenflorian
Copy link
Contributor

@adenflorian adenflorian commented Aug 29, 2020

Partially solves #57 , it hides the airports on the ND when no terrain or weather is showing, but airports will still show when terrain is on and above 500 AGL.

We are hiding the airports by hiding the BingMap, which draws the airports, terrain, and weather.

When weather is on and terrain is off, the weather radar is displayed, and it clears the background with black, so airports are already not displayed when weather is displayed.

When terrain is on and you are at or above 500 AGL, the airport will still be rendered.
We cannot fix this without a patch from Asobo.
There are no function exposed through Coherent that can control whether the airports are rendered or not (that we found).

The user should not see any differences when weather is being displayed (weather on and terrain off), or when terrain is on and the plane is at or above 500 AGL.

Before (weather off, terrain off, 0 AGL) (dev branch):

FlightSimulator_1598740347

After (weather off, terrain off, 0 AGL):

FlightSimulator_1598738390

Before (weather off, terrain on, 0 AGL) (dev branch):

FlightSimulator_1598740355

After (weather off, terrain on, 0 AGL):

FlightSimulator_1598738404

After (weather off, terrain on, 500 AGL):

FlightSimulator_1598738521

The airport is still expected to be seen in the above picture for the reasons mentioned above.

@Benjozork
Copy link
Member

guys, multiple hours of discord streams and group investigation went into this, hope you like it 😂

@adenflorian adenflorian changed the title Hide BingMap when no weather or terrain Hide BingMap on ND when no weather or terrain Aug 29, 2020
@adenflorian
Copy link
Contributor Author

I can run the build.py once it's already been run on the branch itself, since the layout.json is out of date.

@adenflorian adenflorian added the Bug-Vanilla something that was implemented incorrectly in the vanilla unmodded game label Sep 4, 2020
@wpine215 wpine215 changed the base branch from dev-0.1.1 to master September 4, 2020 22:30
@Curtis-VL Curtis-VL merged commit e25ee3d into flybywiresim:master Sep 5, 2020
@adenflorian adenflorian added this to the v0.3.0 milestone Sep 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug-Vanilla something that was implemented incorrectly in the vanilla unmodded game
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants