Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Temporary fix for getAircraftType #8611

Merged
merged 1 commit into from
Apr 5, 2024

Conversation

frankkopp
Copy link
Member

@frankkopp frankkopp commented Apr 5, 2024

Summary of Changes

Temporary fix for getAircraftType - will be redone in PR #8500 or #8599 anyway.

Uses aircraft TITLE simvar which can be overwritten by liveries and is therefore not reliable.

Discord username (if different from GitHub): cdr_maverick

Testing instructions

not required

How to download the PR for QA

Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.

  1. Make sure you are signed in to GitHub
  2. Click on the Checks tab on the PR
  3. On the left side, click on the bottom PR tab
  4. Click on either flybywire-aircraft-a320-neo or flybywire-aircraft-a380-842 download link at the bottom of the page

@frankkopp frankkopp self-assigned this Apr 5, 2024
@frankkopp frankkopp requested a review from 2hwk April 5, 2024 16:12
@frankkopp frankkopp enabled auto-merge (squash) April 5, 2024 16:27
@frankkopp frankkopp merged commit 3b8235a into flybywiresim:master Apr 5, 2024
10 checks passed
@frankkopp frankkopp deleted the fix-aircrafttype-check branch April 5, 2024 16:28
@2hwk 2hwk added this to the v0.12.0 milestone Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✔️ Done
Development

Successfully merging this pull request may close these issues.

2 participants