feat(a380x): port ewd to msfs avionics framework #8701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Saschl
changed the title
# Conflicts: # fbw-a380x/mach.config.js
tracernz
reviewed
Aug 4, 2024
Saschl
commented
Aug 6, 2024
fbw-a380x/src/systems/instruments/src/EWD/shared/ArincValueProvider.ts
Outdated
Show resolved
Hide resolved
| super.onAfterRender(node); | ||
|
|
||
| this.sub | ||
| .on('realTime') |
There was a problem hiding this comment.
Any reason to not use the subs from memoLeft and memoRight to set the strings? Then we would avoid running the logic if nothing changed, or?
There was a problem hiding this comment.
True. Will push a better version with the next commit
| super.onAfterRender(node); | ||
|
|
||
| this.sub | ||
| .on('realTime') |
There was a problem hiding this comment.
Any reason to not use the subs from limitationsLeft and limitationsRight to set the strings? Then we would avoid running the logic if nothing changed, or?
There was a problem hiding this comment.
True. Will push a better version with the next commit
fbw-a380x/src/systems/instruments/src/MsfsAvionicsCommon/gauges.tsx
Outdated
Show resolved
Hide resolved
fbw-a380x/src/systems/instruments/src/MsfsAvionicsCommon/gauges.tsx
Outdated
Show resolved
Hide resolved
Saschl
commented
Aug 7, 2024
Saschl
commented
Aug 7, 2024
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #8723
Summary of Changes
Remark: EWDMessages were updated to enable test with PseudoFWC ECAM update PR, but will be deleted anyways with the other PR.
Screenshots (if necessary)
References
Additional context
Discord username (if different from GitHub):
Testing instructions
How to download the PR for QA
Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.