feat(a380x): PFD THS indicator #8714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flogross89
force-pushed
the
feat-a380x-pfd-ths
branch
from
33b75e4
to
b6de846
Compare
lukecologne
reviewed
Jul 9, 2024
|
Just from the photo I think the left and right padding of the THS % need to be reduced slightly. The left digit and % char are almost touching the border. The reference photo is clearly padded more in the vertical than in the horizontal. In the sim screenshot the padding looks very square. |
# Conflicts: # fbw-a380x/src/systems/instruments/src/PFD/PFD.tsx # fbw-a380x/src/systems/instruments/src/PFD/instrument.tsx
|
2hwk
approved these changes
Jul 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A380X only, no QA needed
Summary of Changes
Implements the THS indicator found in the lower right corner of the PFD.
Active during preflight, take-off and after landing.
Also adds the spoiler indicator in the lower left of the PFD. First iteration, not too accurate.
Screenshots (if necessary)
References
https://www.youtube.com/watch?v=AI8yFhuEa4Q&t=3632s
FCOM
Additional context
Discord username (if different from GitHub): floridude
Testing instructions
How to download the PR for QA
Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.