Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mcdu): INIT B page - ZFW autofill unit conversion while boarding #8760

Merged
merged 4 commits into from
Jul 20, 2024

Conversation

ShreyasKallingal
Copy link
Contributor

Fixes #8758

Summary of Changes

Converts the desired ZFW autofill (always supplied in Kg) to the user unit (Lbs or Kg) during boarding.

Screenshots (if necessary)

N/A

References

N/A

Additional context

N/A

Testing instructions

Steps to reproduce (Copied from issue)

  • set units in EFB to lbs
  • set Pax on payload page to anything but zero
  • start boarding
  • try to load zfw/cg into INIT B page using the top right LSK
  • observe that autofill zfw is in lbs and matches EFB payload page value

How to download the PR for QA

Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.

  1. Make sure you are signed in to GitHub
  2. Click on the Checks tab on the PR
  3. On the left side, find and click on the PR Build tab
  4. Click on either flybywire-aircraft-a320-neo or flybywire-aircraft-a380-842 download link at the bottom of the page

@ShreyasKallingal ShreyasKallingal changed the title Fix fix(mcdu): INIT B page - ZFW autofill unit conversion while boarding Jul 17, 2024
Copy link
Member

@Maximilian-Reuter Maximilian-Reuter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Job!

@LunakisDev
Copy link
Contributor

LunakisDev commented Jul 20, 2024

Quality Assurance Trainee Report

Discord: LunakisLeaks
Object of testing: #8760
Tier of Testing: 1
Date: 20/7/2024

Testing Process:

  1. I set the units in EFB to lbs.

  2. Set PAX on the payload page + start boarding

  3. Loaded ZFW/CG into INIT B page using the top right LSK.

  4. Verified that autofill ZFW is in LBS and matches EFB payload page value.

Negatives:
N/A

Testing Results:
Passed

Conclusions:
LGTM

@Maximilian-Reuter Maximilian-Reuter enabled auto-merge (squash) July 20, 2024 13:03
@Maximilian-Reuter Maximilian-Reuter merged commit 9028379 into flybywiresim:master Jul 20, 2024
7 checks passed
@Maximilian-Reuter
Copy link
Member

@ShreyasKallingal congrats on your first merged Contribution! Sadly you didnt add your discord Username to your PR so we cant assign you your Contributor role. If you message us on the discord we can get that sorted!

@2hwk 2hwk added this to the v0.12.0 milestone Aug 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ✔️ Done
Development

Successfully merging this pull request may close these issues.

ZFW Autofill helper doesnt respect User units while boarding.
4 participants