Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(a380): various W/B fixes #8767

Merged
merged 6 commits into from
Jul 22, 2024

Conversation

lukecologne
Copy link
Member

@lukecologne lukecologne commented Jul 19, 2024

Summary of Changes

This PR adjusts the W/B of the A380. Mainly, it was discovered that the reference datum to model coordinate system conversion was incorrect, resulting in MSFS z-coordinates that were significantly (in order of a few meters) incorrect. This PR now fixes many measurements with the new conversion.
Changes:

  • Adjust L/G contact point positions to match correct positions and weighed L/G loadings
  • Adjust empty weight to match OEW
  • Adjust empty CG to match OEWCG
  • Adjust fuel tank positions to match correct positions
  • Adjust aero center position to match correct 25% chord position.

Also, this PR fixes many of the A380 rust module W/B parameters, such as fuel tank, cargo stations and empty CG position, that were never updated. It also updates the LEMAC and L/G positions according to the changes made.

What was not changed are the actual cargo station positions in the flight model cfg (the rust module values were simply updated to match the old cfg values), since it is not clear to me if they need to be updated with the new offset, or if they are visually placed according to the 3D model, which would mean the values were correct already. Thus I have left them as they were.

Screenshots (if necessary)

References

Additional context

Discord username (if different from GitHub):

Testing instructions

How to download the PR for QA

Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.

  1. Make sure you are signed in to GitHub
  2. Click on the Checks tab on the PR
  3. On the left side, find and click on the PR Build tab
  4. Click on either flybywire-aircraft-a320-neo or flybywire-aircraft-a380-842 download link at the bottom of the page

@lukecologne lukecologne changed the title A380 wb fixes fix(a380): various W/B fixes Jul 19, 2024
@lukecologne lukecologne marked this pull request as ready for review July 20, 2024 23:42
@lukecologne lukecologne merged commit 70ab091 into flybywiresim:master Jul 22, 2024
7 checks passed
@lukecologne lukecologne deleted the a380-wb-fixes branch July 22, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✔️ Done
Development

Successfully merging this pull request may close these issues.

2 participants