Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ini library folder creation #8769

Merged

Conversation

frankkopp
Copy link
Member

Summary of Changes

Fixes creation of the folder for ini files (fuel saving).

Discord username (if different from GitHub): cdr_maverick

Testing instructions

Test if fuel state is saved to an ini file when the work does not already have the "AircraftStates" folder. This folder should be created.

How to download the PR for QA

Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.

  1. Make sure you are signed in to GitHub
  2. Click on the Checks tab on the PR
  3. On the left side, find and click on the PR Build tab
  4. Click on either flybywire-aircraft-a320-neo or flybywire-aircraft-a380-842 download link at the bottom of the page

@frankkopp frankkopp self-assigned this Jul 21, 2024
@Maximilian-Reuter
Copy link
Member

Quality Assurance Trainee Report

Discord : _chaoz_
Object of testing: #8769
Tier of Testing : 1
Date : 21/07/2024

Testing Process:

Tested both 320 and 380 without AircraftStates folder.
Both aircraft created folder with ini file with no issues.

Negatives:
N/A

Testing Results:
Passed

Conclusions:
LGTM

@Maximilian-Reuter Maximilian-Reuter merged commit 93ca033 into flybywiresim:master Jul 21, 2024
9 checks passed
@2hwk 2hwk added this to the v0.12.0 milestone Aug 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ✔️ Done
Development

Successfully merging this pull request may close these issues.

3 participants