This repository has been archived by the owner on Apr 30, 2020. It is now read-only.
Fixed broken Composer versioning for ACF Pro Installation #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am getting the same error when trying to use Any chance to get this merged ? Or any clue where this error might come from ? |
|
@bdebrie just out of interest, are you on MacOS or Linux? |
|
@bdbch I am on MacOS |
|
I guess I just assumed this would work 🙈 Related issue here: AdvancedCustomFields/acf#2 I'll put this on the list for the next release after changing the ACF version to the latest (5.7.7 right now). |
dgrdl
approved these changes
Nov 1, 2018
|
nice! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found out that the versioning change in the package.json lead to the
flynt createtask to break on the composer installation task. Fixes #79 but needs a check for the future. Maybe it's a system difference between MacOS and Windows and how Composer reads the versioning informations in the composer.json.I had no problems installing a new Flynt project with this change/rollback.