Fix problems found by static analysis #492
Conversation
| @@ -14,7 +14,7 @@ | |||
| /** | |||
| * Registers the custom rewrite rule for the 'BaseStyle' route. | |||
| */ | |||
| add_filter('init', function () { | |||
| add_action('init', function () { | |||
There was a problem hiding this comment.
init is an action.
There was a problem hiding this comment.
@szepeviktor: Can confirm this. Thanks!
| @@ -35,8 +35,6 @@ class TimberDynamicResize | |||
|
|
|||
| /** | |||
| * Constructor. | |||
| * | |||
| * @var TimberDynamicResize | |||
There was a problem hiding this comment.
Stray something. No clue what it wants to be.
There was a problem hiding this comment.
@szepeviktor: Can confirm this. Thanks!
| * @param integer|float $w The width of the image. | ||
| * @param integer|float $h The height of the image. |
There was a problem hiding this comment.
It is a float in the code.
There was a problem hiding this comment.
@szepeviktor: Can confirm this. Thanks!
| $data = $data === false ? [] : $data; | ||
| $data = $data === null ? [] : $data; |
There was a problem hiding this comment.
data may be an array or null.
There was a problem hiding this comment.
@szepeviktor: This makes sense. Thanks!
| @@ -80,7 +80,7 @@ public function renderComponent(Environment $env, array $context, $componentName | |||
|
|
|||
| $output = Api::renderComponent($componentName, $data); | |||
|
|
|||
| remove_filter('Flynt/renderComponent', $fn, PHP_INT_MIN, 3); | |||
There was a problem hiding this comment.
remove_filter accepts 3 parameters.
There was a problem hiding this comment.
@szepeviktor: Can confirm this. Thanks!
|
Scrutinizer says
|
Please see comments below.