Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

render config with confp #210

Merged
merged 4 commits into from
May 7, 2021
Merged

render config with confp #210

merged 4 commits into from
May 7, 2021

Conversation

fipwmaqzufheoxq92ebc
Copy link
Contributor

Fixes #209

This PR adds the possibility to preprocess the config-file with confp by using a new (optional) command line argument
--render which should point to confp config file. The mqtt-io config file is used as template.

For that to work I made small changes to confp ( flyte/confp#8 )

This PR is a draft, as confp must be added to the requirements, but I have to wait for a new release with the changes of flyte/confp#8

@flyte
Copy link
Owner

flyte commented Apr 8, 2021

I've made a release incorporating your changes on confp, which is now at 0.4.0.

I like this solution, it's nice and neat. I'll need to spend some time going through it and writing some docs for it, but happy to merge it before doing that.

At some point I'd like to have it render the config file by default, but this gives us a way to test it out nicely in the mean time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Split configuration
2 participants