Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade DHT11/DHT22 backing library #297

Merged
merged 2 commits into from
Jun 2, 2024
Merged

Conversation

pansila
Copy link
Contributor

@pansila pansila commented Nov 13, 2022

Old DHT11/DHT22 backing library Adafruit_DHT is out of maintained and reporting error on my rpi4+python311.

ImportError: cannot import name 'Raspberry_Pi_2_Driver' from 'Adafruit_DHT'

And it has CPU usage hogging problem (~25%).

Upgrade DHT11/DHT22 backing library to adafruit-circuitpython-dht

Old DHT11/DHT22 backing library Adafruit_DHT is out of maintained and reporting error on my rpi4+python311.
` ImportError: cannot import name 'Raspberry_Pi_2_Driver' from 'Adafruit_DHT'`
And it has CPU usage hogging problem (~25%).

Upgrade DHT11/DHT22 backing library to adafruit-circuitpython-dht
@mschlenstedt
Copy link
Contributor

Haven't checked that already, but why did you changed mqtt_io/modules/sensor/bmp085.py for the DHT22/11?

If this is another (new) sensor you should seperate your Pull Requests.

@pansila
Copy link
Contributor Author

pansila commented Aug 2, 2023

Yes, it's a combo PR, I will make it seperated, thanks.

@mschlenstedt
Copy link
Contributor

Thanks!

@linucks
Copy link
Contributor

linucks commented Jun 1, 2024

What's happend with this pull request? The current DHT22 code isn't functional and it looks like this pull request would fix that, it just needs the code for bmp085 separated out. I can submit a new pull request just for DHT22 if that would be helpful?

@mschlenstedt
Copy link
Contributor

I would highly appreciate that!

@BenjiU BenjiU merged commit 98bb92e into flyte:develop Jun 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants