This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
migrate to go module #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
honnix
force-pushed
the
go-module-migration
branch
from
98a8d1d
to
d447e1e
Compare
wild-endeavor
added a commit
to flyteorg/boilerplate
that referenced
this pull request
Jan 23, 2020
This updates the boilerplate to use go modules instead of dep and follows the changes that have already been made: * flyteorg/datacatalog#21 * flyteorg/flytepropeller#38 * flyteorg/flyteadmin#35 * flyteorg/flyteplugins#36 * flyteorg/flytestdlib#50 * flyteorg/flyteidl#27 (depends on flyteorg/flytestdlib#50 to be merged and released)
|
@wild-endeavor PTAL |
chanadian
reviewed
Jan 28, 2020
go.mod
Outdated
| google.golang.org/grpc v1.26.0 | ||
| ) | ||
|
|
||
| // Pin the version of client-go to something that's compatible with katrogan's fork of api and apimachinery |
There was a problem hiding this comment.
@wild-endeavor Do we have to do this even though datacatalog doesn't need this fork?
|
@katrogan could you post some background info here (or link to some) about why your fork of k8s is necessary and what it fixes? |
|
Sigh, yes. I'm trying to upstream changes around quantity proto marshaling which are currently broken on kubernetes master. without these we can't use sidecar plugins. until those changes land we have to use the lyft fork of k8s |
wild-endeavor
approved these changes
Jan 28, 2020
chanadian
approved these changes
Jan 28, 2020
eapolinario
pushed a commit
to eapolinario/flyte
that referenced
this pull request
Aug 21, 2023
This updates the boilerplate to use go modules instead of dep and follows the changes that have already been made: * flyteorg/datacatalog#21 * flyteorg/flytepropeller#38 * flyteorg/flyteadmin#35 * flyteorg/flyteplugins#36 * flyteorg/flytestdlib#50 * flyteorg/flyteidl#27 (depends on flyteorg/flytestdlib#50 to be merged and released)
eapolinario
pushed a commit
that referenced
this pull request
Sep 6, 2023
* migrate to go module * no dep download * no need of dep * update boilerplate as well * no dep * try to fix lint * loader prints too much * incorporate latest boilerplate changes * use latest boilerplate * adding * Remove k8s client-go pinned version Co-authored-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com> Co-authored-by: Andrew Chan <apchan86@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please treat this as a starting point of discussion than actual PR.
Since everything now is on go-1.3, and go module seems to be mature enough, what do you think of the migration?