Migrate to go module and remove old Hive integration tests #36
Conversation
|
@kumare3 PTAL |
honnix
force-pushed
the
go-module-migration
branch
from
7635ac7
to
d83cb70
Compare
|
I had to delete some test files under |
This updates the boilerplate to use go modules instead of dep and follows the changes that have already been made: * flyteorg/datacatalog#21 * flyteorg/flytepropeller#38 * flyteorg/flyteadmin#35 * flyteorg/flyteplugins#36 * flyteorg/flytestdlib#50 * flyteorg/flyteidl#27 (depends on flyteorg/flytestdlib#50 to be merged and released)
|
@wild-endeavor PTAL. I had to delete those non-compilable code otherwise go module is sad. |
|
I think it's fine - those tests were written a while ago and then not kept up to date since we still don't have a cohesive integration testing story. Let me change the title of the PR though to make them easier to find in case I ever want to resurrect them. |
wild-endeavor
changed the title
| @@ -1,201 +0,0 @@ | |||
| // +build manualintegration | |||
There was a problem hiding this comment.
Do we need to delete this?
There was a problem hiding this comment.
I don't think so, but they're not working anymore. I should try to fix them at some point.
| k8s.io/client-go v11.0.0+incompatible | ||
| k8s.io/klog v1.0.0 // indirect | ||
| k8s.io/utils v0.0.0-20200122174043-1e243dd1a584 // indirect | ||
| sigs.k8s.io/controller-runtime v0.4.0 |
There was a problem hiding this comment.
We used to depend on a SHA, is this version inclusive?
There was a problem hiding this comment.
https://github.com/kubernetes-sigs/controller-runtime/releases/tag/v0.4.0 includes sha 40070e2a1958c3d974ba95da883a2bd088137789
|
I ran |
|
ran go mod tidy as well. |
This updates the boilerplate to use go modules instead of dep and follows the changes that have already been made: * flyteorg/datacatalog#21 * flyteorg/flytepropeller#38 * flyteorg/flyteadmin#35 * flyteorg/flyteplugins#36 * flyteorg/flytestdlib#50 * flyteorg/flyteidl#27 (depends on flyteorg/flytestdlib#50 to be merged and released)
migrate to go mod and temporarily remove some broken tests
Some tests are being removed because they need to be updated and that breaks go mod. Can add back in the future. For some reason go mod doesn't know how to respect build tags.