[BUG] GitHub action set for on:release not getting triggered

[samhita-alla]

Describe the bug
A GitHub action set for on:release is not getting triggered when the release is first a draft and later published. Find the relevant GitHub action config here: https://github.com/flyteorg/flytekit/blob/master/.github/workflows/pythonpublish.yml

Expected behavior
GitHub action has to get triggered.

To Reproduce
Steps to reproduce the behavior:

1. Create a draft release in the flytekit repo
2. Publish the release
3. All GitHub actions wouldn't trigger. Check https://github.com/flyteorg/flytekit/actions

GitHub repo(s)
flytekit

[sshiv5768]

Hey, @samhita-alla, I would love to work on this issue.

[samhita-alla]

Hey, @samhita-alla, I would love to work on this issue.

Awesome! Please do. :)

[lordnodd]

Hey @samhita-alla, I am not sure if github workflows have trigger for release created by draft. Here the official docs for event trigger through github actions mention that in a note github-actions-event-trigger.
edit: or am I not understanding this correctly?

[samhita-alla]

Hey @samhita-alla, I am not sure if github workflows have trigger for release created by draft. Here the official docs for event trigger through github actions mention that in a note github-actions-event-trigger. edit: or am I not understanding this correctly?

@evalsocket Do we have a mechanism to fix this issue? As @lordnodd mentioned, GitHub docs clearly say that The release event is not triggered for draft releases..

[yindia]

@lordnodd Yes you are right. Use published trigger in place of created.

Note: The prereleased type will not trigger for pre-releases published from draft releases, but the published type will trigger. If you want a workflow to run when stable and pre-releases publish, subscribe to published instead of released and prereleased.

[samhita-alla]

@lordnodd Yes you are right. Use published trigger in place of created.

Note: The prereleased type will not trigger for pre-releases published from draft releases, but the published type will trigger. If you want a workflow to run when stable and pre-releases publish, subscribe to published instead of released and prereleased.

@lordnodd, would you mind working on this?

[lordnodd]

Cool I'll give this a shot.

[lordnodd]

I made sure to read through the contribution docs, and updated the changes stated by @evalsocket, this is my first open-source commit, let me know if I missed out anywhere :)

[samhita-alla]

I made sure to read through the contribution docs, and updated the changes stated by @evalsocket, this is my first open-source commit, let me know if I missed out anywhere :)

Thank you! Looks like your PR got merged. :)