Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use generated mocks in flyteadmin #149

Open
katrogan opened this issue Dec 27, 2019 · 5 comments
Open

Use generated mocks in flyteadmin #149

katrogan opened this issue Dec 27, 2019 · 5 comments
Labels
flyteadmin Issue for FlyteAdmin Service good first issue Good for newcomers housekeeping Issues that help maintain flyte and keep it tech-debt free stale

Comments

@katrogan
Copy link
Contributor

Currently we have hand-curated mocks which are tedious to add for new interfaces
@katrogan katrogan added the Later label Dec 27, 2019
@katrogan katrogan self-assigned this Dec 27, 2019
@katrogan katrogan mentioned this issue Jul 21, 2020
Merged
8 tasks
@kumare3 kumare3 added flyteadmin Issue for FlyteAdmin Service and removed later labels Feb 8, 2021
@katrogan katrogan mentioned this issue Mar 12, 2021
Merged
8 tasks
@katrogan katrogan removed their assignment Apr 7, 2021
@kumare3
Copy link
Contributor

kumare3 commented Jun 7, 2021

@katrogan do you know the status on this? I think this is resolved right

@katrogan
Copy link
Contributor Author

katrogan commented Jun 7, 2021

@kumare3 it's a WIP. very low priority housekeeping item

@kumare3 kumare3 added this to the 1.0.0 milestone Jun 7, 2021
@kumare3 kumare3 added the housekeeping Issues that help maintain flyte and keep it tech-debt free label Oct 22, 2021
@EngHabu EngHabu modified the milestones: 1.0.0 - Phoenix!, 1.0.1 May 20, 2022
@wild-endeavor wild-endeavor added the good first issue Good for newcomers label Jul 22, 2022
@wild-endeavor wild-endeavor removed this from the 1.0.1 milestone Jul 22, 2022
@katrogan katrogan mentioned this issue Aug 25, 2022
Merged
8 tasks
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 6, 2022
bug; aborted workflows bubble up the error and stay in running (flyte…
03d1c1d 
…org#149)

* Fix aborted workflows

* Added more tests

* Workflow aborted msg
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 6, 2022
@EngHabu
Update propeller to 0.5.14 (flyteorg#149)
44f525f 
* Update propeller

* cleanup
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 6, 2022
@EngHabu @wild-endeavor
@katrogan @tnsetting
Support Google OAuth2 and other OIdC providers (flyteorg#147)
1948047 
* Move scopes to config

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>

* missed

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>

* wip

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>

* Update handlers.go

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>

* go get propeller at v0.5.12 (flyteorg#146)

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>

* Update to using latest flytepropeller v0.5.13 (flyteorg#148)

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>

* Update propeller to 0.5.14 (flyteorg#149)

* Update propeller

* cleanup

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>

* Filter executions by user (flyteorg#150)

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>

* Update CI post migration

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>

* Update codecov link

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>

* Publish raw events (flyteorg#151)

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>

* fix test

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>

* wip

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>

* Fix token retrieval from cookies

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>

* Fix unit tests and lint

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>

* Move to const

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>

* Revert Auth config

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>

* Revert kube config path

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>

* Use access token when posting to IdP

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>

* Ignore refresh token error

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>

* Fix tests

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>

* Expose openId metadata endpoint and expose scopes in /config endpoint

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>

* mod tidy

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>

* rename

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>

* lint

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>

* unit tests

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>

Co-authored-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
Co-authored-by: Katrina Rogan <katrogan9@gmail.com>
Co-authored-by: tnsetting <38207208+tnsetting@users.noreply.github.com>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 20, 2022
@EngHabu
Update CI after migration (flyteorg#149)
e7201cf
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 20, 2022
@dependabot
chore(deps): bump elliptic from 6.5.3 to 6.5.4 (flyteorg#149)
7d149f3 
Bumps [elliptic](https://github.com/indutny/elliptic) from 6.5.3 to 6.5.4.
- [Release notes](https://github.com/indutny/elliptic/releases)
- [Commits](indutny/elliptic@v6.5.3...v6.5.4)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 20, 2022
Add ability to recover executions (flyteorg#149)
ad2585e
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Aug 9, 2023
bug; aborted workflows bubble up the error and stay in running (flyte…
b80ef7d 
…org#149)

* Fix aborted workflows

* Added more tests

* Workflow aborted msg
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Aug 21, 2023
@EngHabu
Update propeller to 0.5.14 (flyteorg#149)
47f801a 
* Update propeller

* cleanup
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Aug 21, 2023
@EngHabu
Update CI after migration (flyteorg#149)
620e45d
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Aug 21, 2023
@EngHabu @wild-endeavor
@katrogan @tnsetting
Support Google OAuth2 and other OIdC providers (flyteorg#147)
6b0e1e9 
* Move scopes to config

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>

* missed

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>

* wip

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>

* Update handlers.go

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>

* go get propeller at v0.5.12 (flyteorg#146)

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>

* Update to using latest flytepropeller v0.5.13 (flyteorg#148)

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>

* Update propeller to 0.5.14 (flyteorg#149)

* Update propeller

* cleanup

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>

* Filter executions by user (flyteorg#150)

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>

* Update CI post migration

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>

* Update codecov link

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>

* Publish raw events (flyteorg#151)

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>

* fix test

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>

* wip

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>

* Fix token retrieval from cookies

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>

* Fix unit tests and lint

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>

* Move to const

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>

* Revert Auth config

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>

* Revert kube config path

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>

* Use access token when posting to IdP

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>

* Ignore refresh token error

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>

* Fix tests

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>

* Expose openId metadata endpoint and expose scopes in /config endpoint

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>

* mod tidy

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>

* rename

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>

* lint

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>

* unit tests

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>

Co-authored-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
Co-authored-by: Katrina Rogan <katrogan9@gmail.com>
Co-authored-by: tnsetting <38207208+tnsetting@users.noreply.github.com>
@github-actions
Copy link

Hello 👋, This issue has been inactive for over 9 months. To help maintain a clean and focused backlog, we'll be marking this issue as stale and will close the issue if we detect no activity in the next 7 days. Thank you for your contribution and understanding! 🙏

@github-actions github-actions bot added the stale label Aug 26, 2023
@github-actions
Copy link

github-actions bot commented Sep 2, 2023

Hello 👋, This issue has been inactive for over 9 months and hasn't received any updates since it was marked as stale. We'll be closing this issue for now, but if you believe this issue is still relevant, please feel free to reopen it. Thank you for your contribution and understanding! 🙏

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Sep 2, 2023
@eapolinario eapolinario reopened this Nov 2, 2023
@github-actions github-actions bot removed the stale label Nov 3, 2023
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Apr 30, 2024
Add ability to recover executions (flyteorg#149)
2d65956
austin362667 pushed a commit to austin362667/flyte that referenced this issue May 7, 2024
@austin362667
Add ability to recover executions (flyteorg#149)
1e2997c
robert-ulbrich-mercedes-benz pushed a commit to robert-ulbrich-mercedes-benz/flyte that referenced this issue Jul 2, 2024
@robert-ulbrich-mercedes-benz
Add ability to recover executions (flyteorg#149)
c57b75c
@github-actions GitHub Actions
Copy link

Hello 👋, this issue has been inactive for over 9 months. To help maintain a clean and focused backlog, we'll be marking this issue as stale and will engage on it to decide if it is still applicable.
Thank you for your contribution and understanding! 🙏

@github-actions github-actions bot added the stale label Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flyteadmin Issue for FlyteAdmin Service good first issue Good for newcomers housekeeping Issues that help maintain flyte and keep it tech-debt free stale
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@EngHabu @eapolinario @katrogan @wild-endeavor @kumare3