Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Slice of simple custom struct is not supported by pflags #150

Closed
bnsblue opened this issue Jan 4, 2020 · 3 comments
Closed

Slice of simple custom struct is not supported by pflags #150

bnsblue opened this issue Jan 4, 2020 · 3 comments
Labels
flytestdlib pri3

Comments

@bnsblue
Copy link
Contributor

bnsblue commented Jan 4, 2020

When I tried to run make generate for this following struct, it fails and complains that it is not marshable/unmarshable.

type Config struct {
         ...
	ClusterConfigs  []ClusterConfig `json:"clusterConfigs" pflag:"-,List of cluster configs. Each of the configs corresponds to a service cluster"`
}
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 6, 2022
@katrogan
Filter executions by user (flyteorg#150)
63e0c27
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 6, 2022
@EngHabu @wild-endeavor
@katrogan @tnsetting
Support Google OAuth2 and other OIdC providers (flyteorg#147)
1948047 
* Move scopes to config

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>

* missed

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>

* wip

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>

* Update handlers.go

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>

* go get propeller at v0.5.12 (flyteorg#146)

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>

* Update to using latest flytepropeller v0.5.13 (flyteorg#148)

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>

* Update propeller to 0.5.14 (flyteorg#149)

* Update propeller

* cleanup

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>

* Filter executions by user (flyteorg#150)

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>

* Update CI post migration

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>

* Update codecov link

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>

* Publish raw events (flyteorg#151)

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>

* fix test

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>

* wip

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>

* Fix token retrieval from cookies

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>

* Fix unit tests and lint

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>

* Move to const

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>

* Revert Auth config

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>

* Revert kube config path

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>

* Use access token when posting to IdP

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>

* Ignore refresh token error

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>

* Fix tests

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>

* Expose openId metadata endpoint and expose scopes in /config endpoint

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>

* mod tidy

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>

* rename

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>

* lint

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>

* unit tests

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>

Co-authored-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
Co-authored-by: Katrina Rogan <katrogan9@gmail.com>
Co-authored-by: tnsetting <38207208+tnsetting@users.noreply.github.com>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 20, 2022
@catalinii
Spark features should not drop spark configs if no features are found (…
275483f 
…flyteorg#150)
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 20, 2022
@yindia
Fix config init command fails if no flyte dir doesn't exist (flyteorg…
ee8b4f2 
…#150)

* Added setup flytedir before config init

Signed-off-by: Yuvraj <code@evalsocket.dev>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Jul 24, 2023
@hamersaw
bumping go version to 1.19 (flyteorg#150)
82d114b 
Signed-off-by: Daniel Rammer <daniel@union.ai>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Aug 21, 2023
@katrogan
Filter executions by user (flyteorg#150)
fd4f6cb
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Aug 21, 2023
@catalinii
Spark features should not drop spark configs if no features are found (…
6927db1 
…flyteorg#150)
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Aug 21, 2023
@EngHabu @wild-endeavor
@katrogan @tnsetting
Support Google OAuth2 and other OIdC providers (flyteorg#147)
6b0e1e9 
* Move scopes to config

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>

* missed

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>

* wip

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>

* Update handlers.go

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>

* go get propeller at v0.5.12 (flyteorg#146)

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>

* Update to using latest flytepropeller v0.5.13 (flyteorg#148)

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>

* Update propeller to 0.5.14 (flyteorg#149)

* Update propeller

* cleanup

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>

* Filter executions by user (flyteorg#150)

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>

* Update CI post migration

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>

* Update codecov link

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>

* Publish raw events (flyteorg#151)

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>

* fix test

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>

* wip

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>

* Fix token retrieval from cookies

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>

* Fix unit tests and lint

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>

* Move to const

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>

* Revert Auth config

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>

* Revert kube config path

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>

* Use access token when posting to IdP

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>

* Ignore refresh token error

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>

* Fix tests

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>

* Expose openId metadata endpoint and expose scopes in /config endpoint

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>

* mod tidy

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>

* rename

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>

* lint

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>

* unit tests

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>

Co-authored-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
Co-authored-by: Katrina Rogan <katrogan9@gmail.com>
Co-authored-by: tnsetting <38207208+tnsetting@users.noreply.github.com>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Aug 21, 2023
@hamersaw
bumping go version to 1.19 (flyteorg#150)
9ad34a1 
Signed-off-by: Daniel Rammer <daniel@union.ai>
@github-actions
Copy link

Hello 👋, This issue has been inactive for over 9 months. To help maintain a clean and focused backlog, we'll be marking this issue as stale and will close the issue if we detect no activity in the next 7 days. Thank you for your contribution and understanding! 🙏

@github-actions github-actions bot added the stale label Aug 26, 2023
@github-actions
Copy link

github-actions bot commented Sep 2, 2023

Hello 👋, This issue has been inactive for over 9 months and hasn't received any updates since it was marked as stale. We'll be closing this issue for now, but if you believe this issue is still relevant, please feel free to reopen it. Thank you for your contribution and understanding! 🙏

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Sep 2, 2023
@eapolinario eapolinario reopened this Nov 2, 2023
@github-actions github-actions bot removed the stale label Nov 3, 2023
@kumare3
Copy link
Contributor

kumare3 commented Nov 5, 2023

This has been resolved. Close

@kumare3 kumare3 closed this as completed Nov 5, 2023
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Apr 30, 2024
@yindia
Fix config init command fails if no flyte dir doesn't exist (flyteorg…
a66e669 
…#150)

* Added setup flytedir before config init

Signed-off-by: Yuvraj <code@evalsocket.dev>
austin362667 pushed a commit to austin362667/flyte that referenced this issue May 7, 2024
@yindia @austin362667
Fix config init command fails if no flyte dir doesn't exist (flyteorg…
e4cdefd 
…#150)

* Added setup flytedir before config init

Signed-off-by: Yuvraj <code@evalsocket.dev>
robert-ulbrich-mercedes-benz pushed a commit to robert-ulbrich-mercedes-benz/flyte that referenced this issue Jul 2, 2024
@yindia @robert-ulbrich-mercedes-benz
Fix config init command fails if no flyte dir doesn't exist (flyteorg…
61605f0 
…#150)

* Added setup flytedir before config init

Signed-off-by: Yuvraj <code@evalsocket.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flytestdlib pri3
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@eapolinario @bnsblue @kumare3