-
Notifications
You must be signed in to change notification settings - Fork 659
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Plugin] Numpy dtypes integration #2753
Comments
Could I work on this? @cosmicBboy |
can i work on this @cosmicBboy |
Hey @cosmicBboy , |
I would like to work on this @cosmicBboy |
Since @techytushar created a PR already, I assigned the issue to Tushar. |
Hello 👋, this issue has been inactive for over 9 months. To help maintain a clean and focused backlog, we'll be marking this issue as stale and will engage on it to decide if it is still applicable. |
I’d like to take on this issue if no one else is working on it. |
Currently, only numpy arrays are supported by the numpy type extension. It would be useful to also support scalar data types as well.
So today, this code will not work:
Error:
Problem: flytekit doesn't know how to handle
numpy.<dtype>
scalar types. The code above will show up anywhere where a user wants to aggregate some values using numpy operations (including sklearn, and probably a bunch of others)Of course the user can always do
float(x.mean())
to convert it to a normal float, but then this kills UX because now we're forcing users to modify otherwise functioning code into some flytekit-nitpicky syntax.Potential Solutions
Resources
The text was updated successfully, but these errors were encountered: