Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Housekeeping] Produce multi-arch images in CI/CD pipelines #2935

Closed
2 tasks done
Tracked by #2917
hajapy opened this issue Sep 29, 2022 · 5 comments
Closed
2 tasks done
Tracked by #2917

[Housekeeping] Produce multi-arch images in CI/CD pipelines #2935

hajapy opened this issue Sep 29, 2022 · 5 comments
Assignees
Labels
hacktoberfest housekeeping Issues that help maintain flyte and keep it tech-debt free
Milestone

Comments

@hajapy
Copy link

hajapy commented Sep 29, 2022

Describe the issue

Update the build pipelines to also produce arm64 images.

At a glance, I think these workflows would need to be updated:

https://github.com/flyteorg/flytetools/blob/master/.github/workflows/docker_build.yml#L34
https://github.com/flyteorg/flytetools/blob/master/.github/workflows/publish.yml#L36
https://github.com/flyteorg/flyte/blob/master/.github/workflows/create_release.yml

I would suggest to look into using the official docker actions if possible:

https://github.com/docker/setup-buildx-action
https://github.com/docker/build-push-action

What if we do not do this?

Unable to use official flyte images on arm64 instances. Users would need to build their own images of all the flyte control plane components.

Related component(s)

No response

Are you sure this issue hasn't been raised already?

  • Yes

Have you read the Code of Conduct?

  • Yes
@hajapy hajapy added the housekeeping Issues that help maintain flyte and keep it tech-debt free label Sep 29, 2022
@prabhu43
Copy link

Hi,
I am interested to pick this up

@prabhu43
Copy link

Hi
I could not find the usage of this workflow https://github.com/flyteorg/flytetools/blob/master/.github/workflows/docker_build.yml.

Can someone help me to gain some context?

@prabhu43
Copy link

prabhu43 commented Oct 11, 2022

@eapolinario I changed 2 workflows in flytetools to publish multi-arch images.
Since https://github.com/flyteorg/flyte/blob/master/.github/workflows/create_release.yml does not have docker build step, its not applicable there.

Please review this PR for flytetools flyteorg/flytetools#66

@wild-endeavor
Copy link
Contributor

@hajapy which images specifically are you referring to? I didn't know this issue was being worked on but others in the community already made changes to the flytekit, flyte-binary and sandbox-bundled images.

@hajapy
Copy link
Author

hajapy commented Jan 6, 2023

@wild-endeavor I was referring to flyteadmin, flytepropeller, datacatalog, flytescheduler and flyteconsole (as well as the -release copies)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest housekeeping Issues that help maintain flyte and keep it tech-debt free
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants