Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Propeller secrets webhook should respect service name #2968

Closed
2 tasks done
Tracked by #2917
wild-endeavor opened this issue Oct 8, 2022 · 2 comments · Fixed by flyteorg/flytepropeller#491
Closed
2 tasks done
Tracked by #2917
Assignees
Labels
bug Something isn't working good first issue Good for newcomers hacktoberfest
Milestone

Comments

@wild-endeavor
Copy link
Contributor

wild-endeavor commented Oct 8, 2022

Secrets Webhook Config Mismatch

Description

The self-signed certs that propeller creates to register the webhook are always set to the const flyte-pod-webhook. But the service name itself is part of the configuration object. We should create the cert to match the config, otherwise the webhook will get a 509 error.

Ask

Update the call path so that the cert generated respects the configuration passed in.

Misc

Are you sure this issue hasn't been raised already?

  • Yes

Have you read the Code of Conduct?

  • Yes
@wild-endeavor wild-endeavor added bug Something isn't working untriaged This issues has not yet been looked at by the Maintainers good first issue Good for newcomers hacktoberfest labels Oct 8, 2022
@wild-endeavor
Copy link
Contributor Author

cc @jeevb

@wild-endeavor wild-endeavor changed the title [BUG] webhook [BUG] Propeller secrets webhook should respect service name Oct 8, 2022
@sisco0
Copy link
Contributor

sisco0 commented Oct 9, 2022

@wild-endeavor Could you kindly set a review over the files in the PR and see what kind of testing could be added?
Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers hacktoberfest
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants