Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Export RetryStrategy to the flyteplugins #469

Closed
12 tasks
catalinii opened this issue Aug 11, 2020 · 0 comments
Closed
12 tasks

[Feature] Export RetryStrategy to the flyteplugins #469

catalinii opened this issue Aug 11, 2020 · 0 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@catalinii
Copy link
Contributor

Motivation: Why do you think this is important?
The plugins tasks should have visibility into the task attempt at run time. For logging purposes or to take decisions based on the attempt number

Goal: What should the final outcome look like, ideally?
By exposing the retry strategy, the task can provide this information to the downstream systems.

Describe alternatives you've considered
The attempt number is already exposed, the issue here is to expose also the maximum number of retry

Flyte component

  • Overall
  • Flyte Setup and Installation scripts
  • Flyte Documentation
  • Flyte communication (slack/email etc)
  • FlytePropeller
  • FlyteIDL (Flyte specification language)
  • Flytekit (Python SDK)
  • FlyteAdmin (Control Plane service)
  • [x ] FlytePlugins
  • DataCatalog
  • FlyteStdlib (common libraries)
  • FlyteConsole (UI)
  • Other

[Optional] Propose: Link/Inline
If you have ideas about the implementation please propose the change. If inline keep it short, if larger then you link to an external document.

Additional context
Add any other context or screenshots about the feature request here.

Is this a blocker for you to adopt Flyte
Please let us know if this makes it impossible to adopt Flyte

@catalinii catalinii added enhancement New feature or request untriaged This issues has not yet been looked at by the Maintainers labels Aug 11, 2020
@kumare3 kumare3 removed the untriaged This issues has not yet been looked at by the Maintainers label Feb 28, 2021
@kumare3 kumare3 added this to the 0.11.0 milestone Feb 28, 2021
@kumare3 kumare3 closed this as completed Feb 28, 2021
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 6, 2022
* Bump FlytePlugins version

Signed-off-by: Kevin Su <pingsutw@apache.org>

* use ZZZ_DeprecatedClusterName instead

Signed-off-by: Kevin Su <pingsutw@apache.org>

* lint

Signed-off-by: Kevin Su <pingsutw@apache.org>

* lint

Signed-off-by: Kevin Su <pingsutw@apache.org>

* go generate

Signed-off-by: Kevin Su <pingsutw@apache.org>

* fix tests

Signed-off-by: Kevin Su <pingsutw@apache.org>

* fix tests

Signed-off-by: Kevin Su <pingsutw@apache.org>

* update workflow name

Signed-off-by: Kevin Su <pingsutw@apache.org>

* add comment

Signed-off-by: Kevin Su <pingsutw@apache.org>

* Address comment

Signed-off-by: Kevin Su <pingsutw@apache.org>

* fix test

Signed-off-by: Kevin Su <pingsutw@apache.org>

* remove cluster name

Signed-off-by: Kevin Su <pingsutw@apache.org>

* remove cluster name

Signed-off-by: Kevin Su <pingsutw@apache.org>

* test

Signed-off-by: Kevin Su <pingsutw@apache.org>

* test

Signed-off-by: Kevin Su <pingsutw@apache.org>

* test

Signed-off-by: Kevin Su <pingsutw@apache.org>

* fix tests

Signed-off-by: Kevin Su <pingsutw@apache.org>

* set timeout

Signed-off-by: Kevin Su <pingsutw@apache.org>

* update viper

Signed-off-by: Kevin Su <pingsutw@apache.org>

* Revert "update viper"

This reverts commit 0ea7a9fdbc3120adaeb42fabca07f56c6cf454ff.

* ping viper 0.9.0

Signed-off-by: Kevin Su <pingsutw@apache.org>

* updated stdlib

Signed-off-by: Kevin Su <pingsutw@apache.org>

* nit

Signed-off-by: Kevin Su <pingsutw@apache.org>

Signed-off-by: Kevin Su <pingsutw@apache.org>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 20, 2022
Signed-off-by: Yuvraj <code@evalsocket.dev>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Aug 9, 2023
* Bump FlytePlugins version

Signed-off-by: Kevin Su <pingsutw@apache.org>

* use ZZZ_DeprecatedClusterName instead

Signed-off-by: Kevin Su <pingsutw@apache.org>

* lint

Signed-off-by: Kevin Su <pingsutw@apache.org>

* lint

Signed-off-by: Kevin Su <pingsutw@apache.org>

* go generate

Signed-off-by: Kevin Su <pingsutw@apache.org>

* fix tests

Signed-off-by: Kevin Su <pingsutw@apache.org>

* fix tests

Signed-off-by: Kevin Su <pingsutw@apache.org>

* update workflow name

Signed-off-by: Kevin Su <pingsutw@apache.org>

* add comment

Signed-off-by: Kevin Su <pingsutw@apache.org>

* Address comment

Signed-off-by: Kevin Su <pingsutw@apache.org>

* fix test

Signed-off-by: Kevin Su <pingsutw@apache.org>

* remove cluster name

Signed-off-by: Kevin Su <pingsutw@apache.org>

* remove cluster name

Signed-off-by: Kevin Su <pingsutw@apache.org>

* test

Signed-off-by: Kevin Su <pingsutw@apache.org>

* test

Signed-off-by: Kevin Su <pingsutw@apache.org>

* test

Signed-off-by: Kevin Su <pingsutw@apache.org>

* fix tests

Signed-off-by: Kevin Su <pingsutw@apache.org>

* set timeout

Signed-off-by: Kevin Su <pingsutw@apache.org>

* update viper

Signed-off-by: Kevin Su <pingsutw@apache.org>

* Revert "update viper"

This reverts commit 0ea7a9fdbc3120adaeb42fabca07f56c6cf454ff.

* ping viper 0.9.0

Signed-off-by: Kevin Su <pingsutw@apache.org>

* updated stdlib

Signed-off-by: Kevin Su <pingsutw@apache.org>

* nit

Signed-off-by: Kevin Su <pingsutw@apache.org>

Signed-off-by: Kevin Su <pingsutw@apache.org>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Apr 30, 2024
Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Apr 30, 2024
Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
austin362667 pushed a commit to austin362667/flyte that referenced this issue May 7, 2024
Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants