This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
Adding retry policy to be available to the plugins #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
catalinii
force-pushed
the
add_retry_info
branch
4 times, most recently
from
f68c493
to
e52bd01
Compare
Codecov Report
@@ Coverage Diff @@
## master #112 +/- ##
==========================================
- Coverage 62.11% 61.74% -0.37%
==========================================
Files 104 104
Lines 6440 5775 -665
==========================================
- Hits 4000 3566 -434
+ Misses 2069 1843 -226
+ Partials 371 366 -5
Continue to review full report at Codecov.
|
catalinii
force-pushed
the
add_retry_info
branch
2 times, most recently
from
583e6f0
to
a407497
Compare
catalinii
force-pushed
the
add_retry_info
branch
from
a407497
to
7027584
Compare
kumare3
reviewed
Aug 17, 2020
| @@ -11,6 +12,7 @@ import ( | |||
| type TaskOverrides interface { | |||
| GetResources() *v1.ResourceRequirements | |||
| GetConfig() *v1.ConfigMap | |||
| GetRetryStrategy() *v1alpha1.RetryStrategy | |||
There was a problem hiding this comment.
Please do not add references to the CRD. These should be references to the core Protobuf objects. This is a cyclic dependency
|
@catalinii this is incorrect. PluginMachinery only references the flyteIDL (proto) defs. the existence of CRD is unknown at this point |
catalinii
force-pushed
the
add_retry_info
branch
2 times, most recently
from
b9ef848
to
b9108e0
Compare
kumare3
reviewed
Oct 5, 2020
catalinii
force-pushed
the
add_retry_info
branch
6 times, most recently
from
92f28df
to
a661204
Compare
catalinii
force-pushed
the
add_retry_info
branch
from
a661204
to
d7e2d19
Compare
kumare3
approved these changes
Oct 5, 2020
eapolinario
pushed a commit
that referenced
this pull request
Sep 6, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
flyteorg/flyte#469