This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
Add GetMaxAttempts() to taskExecutionMetadata #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
catalinii
force-pushed
the
retry
branch
2 times, most recently
from
a6663e3
to
69b9ded
Compare
| @@ -140,13 +145,18 @@ func (t *Handler) newTaskExecutionContext(ctx context.Context, nCtx handler.Node | |||
| } | |||
|
|
|||
| resourceNamespacePrefix := pluginCore.ResourceNamespace(t.resourceManager.GetID()).CreateSubNamespace(pluginCore.ResourceNamespace(pluginID)) | |||
| maxAttempts := uint32(0) | |||
There was a problem hiding this comment.
yeah it looks like we always set the min attempts to 1 + the user specified value: https://github.com/lyft/flytepropeller/blob/96c9ee9e2a9288101de846be8f49fce8c244ea2c/pkg/compiler/transformers/k8s/utils.go#L24
catalinii
force-pushed
the
retry
branch
2 times, most recently
from
21a8391
to
1ae8e27
Compare
|
+1. (one comment) |
anandswaminathan
previously approved these changes
Oct 9, 2020
anandswaminathan
approved these changes
Oct 9, 2020
eapolinario
pushed a commit
to eapolinario/flytepropeller
that referenced
this pull request
Aug 9, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
flyteorg/flyte#469