Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 'needs' from generate_flyte_manifest #4495

Merged
merged 1 commit into from
Nov 29, 2023

Conversation

eapolinario
Copy link
Contributor

Describe your changes

The needs step was not removed from the flyte_generate_manifest gh workflow in #4304. This PR removes it.

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Setup Process

Screenshots

Note to reviewers

Related PRs

Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Nov 29, 2023
@eapolinario eapolinario merged commit 6fb6c6f into master Nov 29, 2023
42 checks passed
@eapolinario eapolinario deleted the remove-needs-from-generate_flyte_manifest branch November 29, 2023 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant