You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Mar 21, 2024. It is now read-only.
The sensitive variables are only required for the actual gear build post-merge, so we may be able to do this without risk after some tweaks. CircleCI allows enabling building of forked PRs, and not exposing secrets configured for the project within CircleCI.
@gsfr I welcome your input on feasibility and prioritization with this. Lacking this issue being resolved, we will need to manually validate the PR from carlos.
1 is done.
2 is moot, since fork PRs automatically get branch names, such as pull/28.
3 is not a concern because CircleCI's automatically-generated deploy key is read-only and only used for checkouts; we use a machine user, stored in the GIT_REMOTE environment variable, for pushing.
I've turned on fork builds and tested with my own fork. Seems to work and CircleCI prints a reassuring message regarding suppression of environment variables.
CircleCI ref : https://circleci.com/docs/fork-pr-builds/
The sensitive variables are only required for the actual gear build post-merge, so we may be able to do this without risk after some tweaks. CircleCI allows enabling building of forked PRs, and not exposing secrets configured for the project within CircleCI.
process
vs.validate
, as the source of the fork may come from the master branch. -- https://github.com/flywheel-io/exchange/blob/master/bin/process-manifests.sh#L224This ticket was spurred by a PR from a fork, which I believe, is a workflow we want to encourage. #26
The text was updated successfully, but these errors were encountered: