feat: add code-editor features to prompt fields #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying hollama with
|
| Latest commit: |
e841fe7
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://36b783aa.hollama.pages.dev |
| Branch Preview URL: | https://57-monaco-editor.hollama.pages.dev |
fmaclen
changed the title
fmaclen
changed the title
fmaclen
commented
Jul 5, 2024
Comment on lines
+81
to
+83
| {#key knowledge} | ||
| <FieldTextEditor {handleSubmit} bind:value={content} /> | ||
| {/key} |
There was a problem hiding this comment.
Setting a key so the component gets remounted whenever knowledge changes.
fmaclen
commented
Jul 5, 2024
Comment on lines
+199
to
+201
| {#key session} | ||
| <FieldTextEditor {handleSubmit} bind:value={prompt} /> | ||
| {/key} |
There was a problem hiding this comment.
Setting a key so the component gets remounted whenever session changes.
fmaclen
commented
Jul 5, 2024
Comment on lines
+14
to
+15
| await expect(modelSelect).toContainText(MOCK_API_TAGS_RESPONSE.models[0].name); | ||
| await expect(modelSelect).toContainText(MOCK_API_TAGS_RESPONSE.models[1].name); |
There was a problem hiding this comment.
Referencing model names from the MOCK_API_TAGS_RESPONSE so we can update the model names in the future without having to find/replace across all of the tests.
NOTE: There are still some hardcoded instances of model names in test/utils.ts.
|
🎉 This PR is included in version 0.2.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Meta + EnterREADME.mdwith more precise/useful information