Crate system implementation #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Missing a lot of validation still and we do not deduplicate crates in the list of crates to build (e.g. `core` might be built several times and each instance would be treated as distinct crates in such a case).
"Handling" means panicking right now since we don't do error messages right now for the crate system implementation. Better than overflowing the stack though.
They used to be local declaration indices but in other parts of the code we did not respect that they are local relative to the namespace not the to current crate (since we did not adjust the code from pre-crate-system). Now, we simply store global declaration indices in a namespace which is way simpler. I also tried keeping the local indices but then defined an accessor method resolving them to global indices given three more arguments (!). It was ugly and error-prone.
fmease
added
A-module-system
And make all tests pass.
fmease
force-pushed
the
crate-system
branch
3 times, most recently
from
538f830
to
b9bb789
Compare
TODOS: * better error messages when deserializing * transfer most of the span information from the `PackageManifest` to the `Package` * use the span information from `Package` for error messages emitted during package resolution * create a better API for deserializing * UI test suite (+ framework) for package resolution * unit tests for the metadata parser
|
Unfinished work is tracked in #100. |
fmease
force-pushed
the
crate-system
branch
from
275c47f
to
f727814
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #14.