add: Admin Tokens list #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrshu
commented
Feb 12, 2024
| <th>Token</th> | ||
| <th>Valid Until</th> | ||
| </tr> | ||
| {% for token in tokens if token.valid %} |
There was a problem hiding this comment.
@tvinar doesn't check the validity against the current time
* Add a view that lists admin user which are not yet invalid * Add a template filter that is capable of obtaining the User object by its id * Add a simple Jinja2 template that lists the emails, tokens, links and valid until dates Signed-off-by: mr.Shu <mr@shu.io>
mrshu
force-pushed
the
mrshu/token-list
branch
from
71347b5
to
78ae8f5
Compare
Adman
reviewed
Feb 12, 2024
|
|
||
|
|
||
| @app.template_filter('get_user') | ||
| def get_user_filter(user_id): |
There was a problem hiding this comment.
This deserves its own file, e.g. template_filters.py. Maybe worth refactoring in the future.
Adman
approved these changes
Feb 12, 2024
tvinar
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a view that lists admin user which are not yet invalid
Add a template filter that is capable of obtaining the User object by its id
Add a simple Jinja2 template that lists the emails, tokens and valid until dates