Fix various code style issues #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most importantly, don't use module names that are the same as the contained class names, as this can lead to errors where the import order matters, as classes are confused with their modules. (For example, this was the case if you sorted imports of hcs/imagexpress/__init__.py before this commit.) We now collect several classes into single (sub-)modules. Usages of `xml`/`lxml` where replaced by alternatives from `defusedxml`. This commit also fixes various other errors reported by `hatch fmt` (i.e. ruff).
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #165 +/- ##
===========================================
+ Coverage 81.03% 91.50% +10.47%
===========================================
Files 35 50 +15
Lines 1687 3295 +1608
Branches 240 345 +105
===========================================
+ Hits 1367 3015 +1648
+ Misses 314 270 -44
- Partials 6 10 +4 ☔ View full report in Codecov by Sentry. |
imagejan
force-pushed
the
code-style-refactor
branch
from
b6d5cd6
to
6ca845b
Compare
Achieved by:
toml-sort --trailing-comma-inline-array -o pyproject.toml .\pyproject.toml
(also sort dependencies)
imagejan
force-pushed
the
code-style-refactor
branch
2 times, most recently
from
64fea52
to
c9fc096
Compare
imagejan
force-pushed
the
code-style-refactor
branch
from
3bf7305
to
d008b11
Compare
|
The remaining ruff errors are now: We should discuss whether we want to fix or ignore them, I'll open a separate issue. I will merge this, bump the version to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most importantly, don't use module names that are the same as the contained class names, as this can lead to errors where the import order matters, as classes are confused with their modules. (For example, this was the case if you sorted imports of
hcs/imagexpress/__init__.pybefore this commit.)We now collect several classes into single (sub-)modules.
Usages of
xml/lxmlwere replaced by alternatives fromdefusedxml.This commit also fixes various other errors reported by
hatch fmt(i.e. ruff).I didn't rename any of the test files yet, although they should also be lower-case in general, and correlate with the now-renamed modules. I'll leave this for a follow-up pull request.
Closes #117.