Allowing custom tokenizer token values #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -103,11 +109,13 @@ var TypeaheadTokenizer = React.createClass({ | |||
| tokenClasses[this.props.customClasses.token] = !!this.props.customClasses.token; | |||
| var classList = classNames(tokenClasses); | |||
| var result = this.state.selected.map(function(selected) { | |||
| var displayString = this.props.displayOption(selected); | |||
| var value = Accessor.valueForOption(this.props.formInputOption, selected); | |||
There was a problem hiding this comment.
What do you think about making it so that the default value for the token is the display string if no formInputOption is set?
|
Defaulting to |
|
Thank you SO much for cleaning up this code, also! This is great! |
|
Might need to do some post processing on the default if the display value is an HTMLElement instead of text, but we can burn that bridge when we get to it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Typeaheadhas theformInputOptionproperty, which can be used to transform a complex option to a form input value. It would be nice to have the same thing forTokenizer.